Re: [U-Boot] [PATCH] bootm: fix conditional controlling call to fixup_silent_linux

2013-08-04 Thread Simon Glass
Hi Paul, On Sun, Aug 4, 2013 at 8:43 PM, Paul B. Henson wrote: > On Sun, Aug 04, 2013 at 02:10:14PM -0600, Simon Glass wrote: > > > But which board does it actually break, please? > > I don't think any of the default configs included in u-boot would have > broken, while some of them define CONFI

Re: [U-Boot] [PATCH] bootm: fix conditional controlling call to fixup_silent_linux

2013-08-04 Thread Paul B. Henson
On Sun, Aug 04, 2013 at 02:10:14PM -0600, Simon Glass wrote: > But which board does it actually break, please? I don't think any of the default configs included in u-boot would have broken, while some of them define CONFIG_SILENT_CONSOLE, none of them define CONFIG_SILENT_U_BOOT_ONLY. I was worki

Re: [U-Boot] [PATCH] bootm: fix conditional controlling call to fixup_silent_linux

2013-08-04 Thread Paul B. Henson
Looks like this was broken in commit 35fc84fa1ff51e15ecd3e464dac87eb105ffed30, the refactor changed the conditional test when the code was moved. On Sat, Aug 03, 2013 at 09:29:09PM -0700, Paul B. Henson wrote: > This function is only defined if CONFIG_SILENT_CONSOLE is set and > CONFIG_SILENT_U_B

Re: [U-Boot] [PATCH] bootm: fix conditional controlling call to fixup_silent_linux

2013-08-04 Thread Simon Glass
Hi Paul, On Sun, Aug 4, 2013 at 1:59 PM, Paul B. Henson wrote: > Looks like this was broken in commit > 35fc84fa1ff51e15ecd3e464dac87eb105ffed30, > the refactor changed the conditional test when the code was moved. > > This looks right. Acked-by: Simon Glass But which board does it actually b

[U-Boot] [PATCH] bootm: fix conditional controlling call to fixup_silent_linux

2013-08-03 Thread Paul B. Henson
This function is only defined if CONFIG_SILENT_CONSOLE is set and CONFIG_SILENT_U_BOOT_ONLY is not set, the call to it should be based on the same conditions. Signed-off-by: Paul B. Henson --- common/cmd_bootm.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/common/cmd