Re: [U-Boot] [PATCH] blackfin: gpio: Use proper mask for comparing function

2013-06-30 Thread Sonic Zhang
Acked-by: Sonic Zhang On Fri, Jun 28, 2013 at 2:45 PM, Axel Lin wrote: > The function return from P_FUNCT2MUX(per) takes 2 bits, however > for BF537_FAMILY with offset != 1 the function is 1 bit. > > Also has small refactor for better readability. > In portmux_setup(), it looks odd having "muxre

[U-Boot] [PATCH] blackfin: gpio: Use proper mask for comparing function

2013-06-27 Thread Axel Lin
The function return from P_FUNCT2MUX(per) takes 2 bits, however for BF537_FAMILY with offset != 1 the function is 1 bit. Also has small refactor for better readability. In portmux_setup(), it looks odd having "muxreg &= ~(3 << 1);" while in current code we do muxreg |= (function << offset);. Sign