Re: [U-Boot] [PATCH] arm: enable unaligned access on ARMv7

2012-06-27 Thread Tetsuyuki Kobayashi
Hi Rob and all, >>> >>> Am Dienstag, den 05.06.2012, 12:42 -0600 schrieb Stephen Warren: On 06/05/2012 11:47 AM, Lucas Stach wrote: > Recent toolchains default to using the hardware feature for > unaligned access on ARM v7, rather than doing the software > fallback. According to A

Re: [U-Boot] [PATCH] arm: enable unaligned access on ARMv7

2012-06-26 Thread Rob Herring
On 06/22/2012 04:15 AM, Albert ARIBAUD wrote: > Hi Lucas, > > On Tue, 05 Jun 2012 21:06:20 +0200, Lucas Stach wrote: >> Hi Stephen, >> >> Am Dienstag, den 05.06.2012, 12:42 -0600 schrieb Stephen Warren: >>> On 06/05/2012 11:47 AM, Lucas Stach wrote: Recent toolchains default to using the har

Re: [U-Boot] [PATCH] arm: enable unaligned access on ARMv7

2012-06-25 Thread Wolfgang Denk
Dear Aneesh V, In message <4fe8dce7.7090...@ti.com> you wrote: > > > What is the (non-contrived) problem to which allowing mis-aligned > > accesses would be a solution? > > memcpy() when there is a mismatch in the alignment of source and > destination buffers. Let's say the source buffer is 4 by

Re: [U-Boot] [PATCH] arm: enable unaligned access on ARMv7

2012-06-25 Thread Aneesh V
Hi Albert, On 06/25/2012 01:34 PM, Albert ARIBAUD wrote: Hi Aneesh, BTW, I agree that enabling un-aligned access is not a bad idea. Just being "not a bad idea" is not enough for me to accept this. It will have to be the sole sound solution to a problem, and at this point, I do not think it i

Re: [U-Boot] [PATCH] arm: enable unaligned access on ARMv7

2012-06-25 Thread Lucas Stach
Hi Albert, Am Montag, den 25.06.2012, 22:17 +0200 schrieb Albert ARIBAUD: > Hi Lucas, > > On Sun, 24 Jun 2012 08:30:19 +0200, Lucas Stach wrote: > > Hi Albert, > > > > Am Samstag, den 23.06.2012, 11:01 +0200 schrieb Albert ARIBAUD: > > [snip] > > > > >> But apart from this, we certainly have si

Re: [U-Boot] [PATCH] arm: enable unaligned access on ARMv7

2012-06-25 Thread Albert ARIBAUD
Hi Aneesh, > >> BTW, I agree that enabling un-aligned access is not a bad idea. > > > > Just being "not a bad idea" is not enough for me to accept this. It > > will have to be the sole sound solution to a problem, and at this > > point, I do not think it is as far as USB structure mis-alignement >

Re: [U-Boot] [PATCH] arm: enable unaligned access on ARMv7

2012-06-23 Thread Lucas Stach
Hi Albert, Am Samstag, den 23.06.2012, 11:01 +0200 schrieb Albert ARIBAUD: [snip] > > >> But apart from this, we certainly have situations where we have > > >> unaligned accesses that are justified and could not be removed. > > >> [...] > > >> I cannot see how enabling a hardware feature can be se

Re: [U-Boot] [PATCH] arm: enable unaligned access on ARMv7

2012-06-23 Thread Måns Rullgård
Albert ARIBAUD writes: >> >> I cannot see how enabling a hardware feature can be seen as >> >> allowing of lax behaviour. As some of the USB structs are used to >> >> access hardware registers, we can not align every struct there. > > If the access is in true RAM, then we can always realign the d

Re: [U-Boot] [PATCH] arm: enable unaligned access on ARMv7

2012-06-23 Thread V, Aneesh
Hi Albert, On Sat, Jun 23, 2012 at 2:01 AM, Albert ARIBAUD wrote: > Hi Aneesh, > > On Fri, 22 Jun 2012 15:13:39 -0700, Aneesh V wrote: >> On 06/22/2012 03:11 PM, Aneesh V wrote: >> > +Tom >> > >> > Hi Lucas, >> > >> > On 06/22/2012 04:47 AM, Lucas Stach wrote: >> >> Hi Albert, >> >> >> >> Am Fre

Re: [U-Boot] [PATCH] arm: enable unaligned access on ARMv7

2012-06-23 Thread Albert ARIBAUD
Hi Aneesh, On Fri, 22 Jun 2012 15:13:39 -0700, Aneesh V wrote: > On 06/22/2012 03:11 PM, Aneesh V wrote: > > +Tom > > > > Hi Lucas, > > > > On 06/22/2012 04:47 AM, Lucas Stach wrote: > >> Hi Albert, > >> > >> Am Freitag, den 22.06.2012, 13:16 +0200 schrieb Albert ARIBAUD: > >>> I am not too happ

Re: [U-Boot] [PATCH] arm: enable unaligned access on ARMv7

2012-06-22 Thread Aneesh V
On 06/22/2012 03:11 PM, Aneesh V wrote: +Tom Hi Lucas, On 06/22/2012 04:47 AM, Lucas Stach wrote: Hi Albert, Am Freitag, den 22.06.2012, 13:16 +0200 schrieb Albert ARIBAUD: Hi Lucas, Linux in particular does reinitialize this state and I expect any reasonable OS to do so. Then what is th

Re: [U-Boot] [PATCH] arm: enable unaligned access on ARMv7

2012-06-22 Thread Aneesh V
+Tom Hi Lucas, On 06/22/2012 04:47 AM, Lucas Stach wrote: Hi Albert, Am Freitag, den 22.06.2012, 13:16 +0200 schrieb Albert ARIBAUD: Hi Lucas, Linux in particular does reinitialize this state and I expect any reasonable OS to do so. Then what is the point of enabling it on U-Boot? Does it

Re: [U-Boot] [PATCH] arm: enable unaligned access on ARMv7

2012-06-22 Thread Lucas Stach
Hi Albert, Am Freitag, den 22.06.2012, 13:16 +0200 schrieb Albert ARIBAUD: > Hi Lucas, > > > > > Linux in particular does reinitialize this state and I expect any > > > > reasonable OS to do so. > > > > > > Then what is the point of enabling it on U-Boot? Does it fix some > > > issue whereby som

Re: [U-Boot] [PATCH] arm: enable unaligned access on ARMv7

2012-06-22 Thread Albert ARIBAUD
Hi Lucas, > > > Linux in particular does reinitialize this state and I expect any > > > reasonable OS to do so. > > > > Then what is the point of enabling it on U-Boot? Does it fix some > > issue whereby some mis-aligned piece of data cannot be properly > > aligned? > > > Yes, it fixes U-Boot US

Re: [U-Boot] [PATCH] arm: enable unaligned access on ARMv7

2012-06-22 Thread Lucas Stach
Am Freitag, den 22.06.2012, 11:15 +0200 schrieb Albert ARIBAUD: > Hi Lucas, > > On Tue, 05 Jun 2012 21:06:20 +0200, Lucas Stach wrote: > > Hi Stephen, > > > > Am Dienstag, den 05.06.2012, 12:42 -0600 schrieb Stephen Warren: > > > On 06/05/2012 11:47 AM, Lucas Stach wrote: > > > > Recent toolchai

Re: [U-Boot] [PATCH] arm: enable unaligned access on ARMv7

2012-06-22 Thread Albert ARIBAUD
Hi Lucas, On Tue, 05 Jun 2012 21:06:20 +0200, Lucas Stach wrote: > Hi Stephen, > > Am Dienstag, den 05.06.2012, 12:42 -0600 schrieb Stephen Warren: > > On 06/05/2012 11:47 AM, Lucas Stach wrote: > > > Recent toolchains default to using the hardware feature for > > > unaligned access on ARM v7, r

Re: [U-Boot] [PATCH] arm: enable unaligned access on ARMv7

2012-06-05 Thread Lucas Stach
Hi Stephen, Am Dienstag, den 05.06.2012, 12:42 -0600 schrieb Stephen Warren: > On 06/05/2012 11:47 AM, Lucas Stach wrote: > > Recent toolchains default to using the hardware feature for unaligned > > access on > > ARM v7, rather than doing the software fallback. According to ARM this is > > safe

Re: [U-Boot] [PATCH] arm: enable unaligned access on ARMv7

2012-06-05 Thread Stephen Warren
On 06/05/2012 11:47 AM, Lucas Stach wrote: > Recent toolchains default to using the hardware feature for unaligned access > on > ARM v7, rather than doing the software fallback. According to ARM this is safe > as all v7 implementations have to support this feature. > (http://infocenter.arm.com/hel

[U-Boot] [PATCH] arm: enable unaligned access on ARMv7

2012-06-05 Thread Lucas Stach
Recent toolchains default to using the hardware feature for unaligned access on ARM v7, rather than doing the software fallback. According to ARM this is safe as all v7 implementations have to support this feature. (http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0471c/BABJFFAE.html)