Re: [U-Boot] [PATCH] arm: add 8-byte alignment for ABI compliance before board_init_f

Dear Heiko Schocher, In message <1289544835-24425-1-git-send-email...@denx.de> you wrote: > suggested from Daniel Hobi > > Tested on following boards: > arm1136: qong > armv7: omap3_beagle > arm926ejs: magnesium, tx25 > > Signed-off-by: Heiko Schocher > cc: Daniel Hobi > cc: Albert ARIBAUD >

Re: [U-Boot] [PATCH] arm: add 8-byte alignment for ABI compliance before board_init_f

Dear Graeme Russ, In message <4cdd0d1f.7010...@gmail.com> you wrote: > > > Passing gd as parameter makes no sense, thoug, as it's global data and > > we reserve a register to store it's address, so it can always be used > > with minimal overhead. > > Which is a really nice idea if you have a regi

Re: [U-Boot] [PATCH] arm: add 8-byte alignment for ABI compliance before board_init_f

On 12/11/10 19:50, Wolfgang Denk wrote: > Dear Reinhard Meyer, > > In message <4cdce769.8080...@emk-elektronik.de> you wrote: >> >> Is bootflag ever used? If not, why not change the parameter to >> give the gd address to board_init_f? > > No, bootflag is never used and could / should be removed.

Re: [U-Boot] [PATCH] arm: add 8-byte alignment for ABI compliance before board_init_f

On 12/11/10 18:19, Heiko Schocher wrote: > Hello Reinhard, > > Reinhard Meyer wrote: >> Dear Heiko Schocher, >>> diff --git a/arch/arm/cpu/sa1100/start.S b/arch/arm/cpu/sa1100/start.S >> Is bootflag ever used? If not, why not change the parameter to > > No. > >> give the gd address to board_ini

Re: [U-Boot] [PATCH] arm: add 8-byte alignment for ABI compliance before board_init_f

Dear Reinhard Meyer, In message <4cdce769.8080...@emk-elektronik.de> you wrote: > > Is bootflag ever used? If not, why not change the parameter to > give the gd address to board_init_f? No, bootflag is never used and could / should be removed. Passing gd as parameter makes no sense, thoug, as it

Re: [U-Boot] [PATCH] arm: add 8-byte alignment for ABI compliance before board_init_f

Hello Albert, Albert ARIBAUD wrote: > Le 12/11/2010 07:53, Heiko Schocher a écrit : >> suggested from Daniel Hobi >> >> Tested on following boards: >> arm1136: qong >> armv7: omap3_beagle >> arm926ejs: magnesium, tx25 >> >> Signed-off-by: Heiko Schocher >> cc: Daniel Hobi >> cc: Albert ARIBAUD >

Re: [U-Boot] [PATCH] arm: add 8-byte alignment for ABI compliance before board_init_f

Le 12/11/2010 08:19, Heiko Schocher a écrit : >> One further thought, why not init the reserved register in assembly and >> remove the gd relevant code in C? But that bears some risk if the register >> is changed and the assembly is forgotten to adapt.. > > No, I think this is to risky ... It is

Re: [U-Boot] [PATCH] arm: add 8-byte alignment for ABI compliance before board_init_f

Le 12/11/2010 07:53, Heiko Schocher a écrit : > suggested from Daniel Hobi > > Tested on following boards: > arm1136: qong > armv7: omap3_beagle > arm926ejs: magnesium, tx25 > > Signed-off-by: Heiko Schocher > cc: Daniel Hobi > cc: Albert ARIBAUD I'm a bit uneasy about having the symbol unaligned

Re: [U-Boot] [PATCH] arm: add 8-byte alignment for ABI compliance before board_init_f

Hello Reinhard, Reinhard Meyer wrote: > Dear Heiko Schocher, >> diff --git a/arch/arm/cpu/sa1100/start.S b/arch/arm/cpu/sa1100/start.S >> index ace0c07..91cdd72 100644 >> --- a/arch/arm/cpu/sa1100/start.S >> +++ b/arch/arm/cpu/sa1100/start.S >> @@ -152,6 +152,7 @@ reset: >> /* Set stackpointer i

Re: [U-Boot] [PATCH] arm: add 8-byte alignment for ABI compliance before board_init_f

Dear Heiko Schocher, > diff --git a/arch/arm/cpu/sa1100/start.S b/arch/arm/cpu/sa1100/start.S > index ace0c07..91cdd72 100644 > --- a/arch/arm/cpu/sa1100/start.S > +++ b/arch/arm/cpu/sa1100/start.S > @@ -152,6 +152,7 @@ reset: > /* Set stackpointer in internal RAM to call board_init_f */ > call

[U-Boot] [PATCH] arm: add 8-byte alignment for ABI compliance before board_init_f

suggested from Daniel Hobi Tested on following boards: arm1136: qong armv7: omap3_beagle arm926ejs: magnesium, tx25 Signed-off-by: Heiko Schocher cc: Daniel Hobi cc: Albert ARIBAUD --- arch/arm/cpu/arm1136/start.S |1 + arch/arm/cpu/arm1176/start.S |1 + arch/arm/cpu/arm720t/start