Allesandro,
On Thu, Mar 17, 2011 at 8:30 AM, Alessandro Rubini
wrote:
>
>>> It looks like most of your uses are standalone functions that would
>>> function just fine on their own. Is there a reason you prefer to have
>>> them in a C-file instead of in an assembly file?
>
>> Just laziness ;)
>>
Peter,
On Thu, Mar 17, 2011 at 7:32 AM, Peter Tyser wrote:
> Hi Tom,
>
>> >> >
>> >> >> + /* Is PLL-X already running? */
>> >> >> + reg = readl(&clkrst->crc_pllx_base);
>> >> >> + if (reg & PLL_ENABLE)
>> >> >> + return;
>> >> >> +
>> >> >> + /* Do PLLX init if it isn
>> It looks like most of your uses are standalone functions that would
>> function just fine on their own. Is there a reason you prefer to have
>> them in a C-file instead of in an assembly file?
> Just laziness ;)
> I'll move these to a new .S file in the next patchset.
Actually, writing assem
Hi Tom,
> >> >
> >> >> + /* Is PLL-X already running? */
> >> >> + reg = readl(&clkrst->crc_pllx_base);
> >> >> + if (reg & PLL_ENABLE)
> >> >> + return;
> >> >> +
> >> >> + /* Do PLLX init if it isn't running, but BootROM sets it, so TBD
> >> >> */
> >> >> +}
> >> >
>
Peter,
On Mon, Mar 14, 2011 at 3:20 PM, Peter Tyser wrote:
> Hi Tom,
>
>
>
>> >> +static void init_pll_x(void)
>> >> +{
>> >> + struct clk_rst_ctlr *clkrst = (struct clk_rst_ctlr *)NV_PA_CLK_RST
>> >> _BASE;
>> >> + u32 reg;
>> >
>> > The spaces in front of "reg" can be removed. Di
Hi Tom,
> >> +static void init_pll_x(void)
> >> +{
> >> + struct clk_rst_ctlr *clkrst = (struct clk_rst_ctlr
> >> *)NV_PA_CLK_RST_BASE;
> >> + u32 reg;
> >
> > The spaces in front of "reg" can be removed. Ditto for all
> > functions/variables.
> Not sure what you mean, here, Peter.
Peter,
On Mon, Mar 14, 2011 at 8:33 AM, Peter Tyser wrote:
> Hi Tom,
> I'm not too familiar with the architecture, so many comments are
> aesthetic. It would be a good idea to run the patch through
> checkpatch.pl too.
I run checkpatch on every submission. Only 1 warning was generated
(about an
Albert,
On Sun, Mar 13, 2011 at 10:46 AM, Albert ARIBAUD wrote:
> Le 16/02/2011 21:26, Tom Warren a écrit :
>>
>> Signed-off-by: Tom Warren
>> ---
>> arch/arm/cpu/armv7/start.S | 6 +
>> arch/arm/cpu/armv7/tegra2/Makefile | 2 +-
>
>> arch/arm/cpu/armv7/tegra2/ap20.
Hi Tom,
I'm not too familiar with the architecture, so many comments are
aesthetic. It would be a good idea to run the patch through
checkpatch.pl too.
> diff --git a/arch/arm/cpu/armv7/start.S b/arch/arm/cpu/armv7/start.S
> index 684f2d2..50a1725 100644
> --- a/arch/arm/cpu/armv7/start.S
> +++ b
Le 16/02/2011 21:26, Tom Warren a écrit :
> Signed-off-by: Tom Warren
> ---
> arch/arm/cpu/armv7/start.S |6 +
> arch/arm/cpu/armv7/tegra2/Makefile |2 +-
> arch/arm/cpu/armv7/tegra2/ap20.c | 490
>
This one has an extra e
Albert,
On Tue, Feb 22, 2011 at 4:57 PM, Albert ARIBAUD wrote:
> Hi Tom,
>
> Le 23/02/2011 00:41, Tom Warren a écrit :
>>
>> Anyone willing to review this? I'd like to get it pulled in to
>> Albert's arm repo ASAP.
>
> I should be able to review it during the week-end--not before, sorry.
>
Any ch
Albert,
On Tue, Feb 22, 2011 at 4:57 PM, Albert ARIBAUD wrote:
> Hi Tom,
>
> Le 23/02/2011 00:41, Tom Warren a écrit :
>>
>> Anyone willing to review this? I'd like to get it pulled in to
>> Albert's arm repo ASAP.
>
> I should be able to review it during the week-end--not before, sorry.
>
Thank
Hi Tom,
Le 23/02/2011 00:41, Tom Warren a écrit :
> Anyone willing to review this? I'd like to get it pulled in to
> Albert's arm repo ASAP.
I should be able to review it during the week-end--not before, sorry.
Note however that since this is not a bugfix and it came after the merge
window clos
Anyone willing to review this? I'd like to get it pulled in to
Albert's arm repo ASAP.
Thanks,
Tom
On Wed, Feb 16, 2011 at 1:26 PM, Tom Warren wrote:
> Signed-off-by: Tom Warren
> ---
> arch/arm/cpu/armv7/start.S | 6 +
> arch/arm/cpu/armv7/tegra2/Makefile | 2 +-
Signed-off-by: Tom Warren
---
arch/arm/cpu/armv7/start.S |6 +
arch/arm/cpu/armv7/tegra2/Makefile |2 +-
arch/arm/cpu/armv7/tegra2/ap20.c | 490
arch/arm/cpu/armv7/tegra2/ap20.h | 105 ++
arch/arm/include/asm/a
15 matches
Mail list logo
