Re: [U-Boot] [PATCH] arm: Adds saving of Kernel boot args to NAND flash

2011-07-08 Thread Scott Wood
On Fri, 8 Jul 2011 09:53:46 +0200 Simon Schwarz wrote: > > Look at bootm subcommands to run just the portion of the existing bootm > > functionality that you need.  Type "help bootm" for details. > > Of course I could implement a subcommand - actually this seems to be > the best method. > > IMH

Re: [U-Boot] [PATCH] arm: Adds saving of Kernel boot args to NAND flash

2011-07-08 Thread Simon Schwarz
> Look at bootm subcommands to run just the portion of the existing bootm > functionality that you need.  Type "help bootm" for details. Of course I could implement a subcommand - actually this seems to be the best method. IMHO "prep" would be the right one to use? correct? Regards Simon ___

Re: [U-Boot] [PATCH] arm: Adds saving of Kernel boot args to NAND flash

2011-07-07 Thread Scott Wood
On Thu, 7 Jul 2011 17:50:12 +0200 Simon Schwarz wrote: > > But that's not what bootm is for.  If you're doing something new, it should > > be in a new command -- or in a script of existing commands. > > True. The upper patch was the quickest way to do this. > > I implemented a first test for a

Re: [U-Boot] [PATCH] arm: Adds saving of Kernel boot args to NAND flash

2011-07-07 Thread Simon Schwarz
> But that's not what bootm is for.  If you're doing something new, it should > be in a new command -- or in a script of existing commands. True. The upper patch was the quickest way to do this. I implemented a first test for a command. This is a bit ugly because I have to rip apart bootm. For no

Re: [U-Boot] [PATCH] arm: Adds saving of Kernel boot args to NAND flash

2011-07-06 Thread Albert ARIBAUD
Hi Simon, Le 05/07/2011 15:20, Simon Schwarz a écrit : > This is an RFC on how this can be done. Then please tag the subject with [RFC] next time! Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listi

Re: [U-Boot] [PATCH] arm: Adds saving of Kernel boot args to NAND flash

2011-07-06 Thread Scott Wood
On Wed, 6 Jul 2011 09:42:52 +0200 Simon Schwarz wrote: > Hi, > > thanks for your feedback! > > I will address the style problems - didn't run checkpatch for the RFC > - sorry my fault. > > > Why are you writing to NAND as part of bootm? > > > > If you just want access to the results of the FDT

Re: [U-Boot] [PATCH] arm: Adds saving of Kernel boot args to NAND flash

2011-07-06 Thread Simon Schwarz
> If you just want access to the results of the FDT/ATAG preparation that > bootm does, consider using the bootm subcommands to prepare them, then > normal U-Boot commands to write to NAND. Me again. I rethought and the problem with bootm is that the subfunctions (bootm_linux_fdt/do_bootm_linux) ar

Re: [U-Boot] [PATCH] arm: Adds saving of Kernel boot args to NAND flash

2011-07-06 Thread Simon Schwarz
Hi, thanks for your feedback! I will address the style problems - didn't run checkpatch for the RFC - sorry my fault. > Why are you writing to NAND as part of bootm? > > If you just want access to the results of the FDT/ATAG preparation that > bootm does, consider using the bootm subcommands to

Re: [U-Boot] [PATCH] arm: Adds saving of Kernel boot args to NAND flash

2011-07-05 Thread Scott Wood
On Tue, 5 Jul 2011 15:20:39 +0200 Simon Schwarz wrote: > +#ifdef CONFIG_SAVE_BOOT_ARGS > +/* This function writes given bootparams to NAND flash > + * adr: Start adress of Kernel parameter image (ATAGS, FDT) > + * length: length of the image in byte > + * > + * borrowd heavily from common/cmd_n

[U-Boot] [PATCH] arm: Adds saving of Kernel boot args to NAND flash

2011-07-05 Thread Simon Schwarz
Adds the saving of either ATAGS or FDT kernel argument image to NAND flash. This image then can be used in SPL boot. This adds two CONFIG_ paramter to board configuration (in this RFC as example added to devkit8000.h): CONFIG_SAVE_BOOT_ARGS makes the feature active CONFIG_BOOT_ARGS_NAND