Re: [U-Boot] [PATCH] andes_spi: add andes_spi interface

2011-04-24 Thread Mike Frysinger
On Sun, Apr 24, 2011 at 11:37 PM, wrote: >> > --- /dev/null >> > +++ b/drivers/spi/andes_spi.h >> >> i cant think of any reason other code would want to include this ... >> so please put this header in drivers/spi/ > > I am confused with this comment. > > According to the  summary of this patch >

Re: [U-Boot] [PATCH] andes_spi: add andes_spi interface

2011-04-24 Thread macpaul
Hi Mike, > > --- /dev/null > > +++ b/drivers/spi/andes_spi.h > > i cant think of any reason other code would want to include this ... > so please put this header in drivers/spi/ > -mike I am confused with this comment. According to the summary of this patch drivers/spi/Makefile|1 +

Re: [U-Boot] [PATCH] andes_spi: add andes_spi interface

2011-04-23 Thread Mike Frysinger
On Sat, Apr 23, 2011 at 12:34 AM, Macpaul Lin wrote: >> > +       ds->slave.bus = bus; >> > +       ds->slave.cs = cs; >> > +       ds->regs = (struct andes_spi_regs *)CONFIG_SYS_SPI_BASE; >> > +       ds->freq = max_hz; >> >> your spi controller has no frequency limit ?  your spi_claim_bus >> indi

Re: [U-Boot] [PATCH] andes_spi: add andes_spi interface

2011-04-22 Thread Macpaul Lin
Hi Mike, > + ds->slave.bus = bus; > > + ds->slave.cs = cs; > > + ds->regs = (struct andes_spi_regs *)CONFIG_SYS_SPI_BASE; > > + ds->freq = max_hz; > > your spi controller has no frequency limit ? your spi_claim_bus > indicates that there is ... > > Hey, it really strange b

Re: [U-Boot] [PATCH] andes_spi: add andes_spi interface

2011-04-22 Thread Mike Frysinger
On Fri, Apr 22, 2011 at 3:20 AM, Macpaul Lin wrote: > +#ifdef DEBUG > +#define debug(fmt, args...)    printf(fmt, ##args) > +#else > +#define debug(fmt, args...) > +#endif common.h already provides this for you > +void andes_spi_spit_en(struct andes_spi_slave *ds) > +{ > +       debug("%s: dcr: %

[U-Boot] [PATCH] andes_spi: add andes_spi interface

2011-04-22 Thread Macpaul Lin
andes_spi is an spi interface developed by Andes Tech. Signed-off-by: Macpaul Lin --- drivers/spi/Makefile|1 + drivers/spi/andes_spi.c | 302 +++ drivers/spi/andes_spi.h | 128 3 files changed, 431 insertions(+), 0 delet