Re: [U-Boot] [PATCH] add u-boot sja1000/can support

2009-10-26 Thread Wolfgang Denk
Dear "miaofng", In message <200910241217470153...@gmail.com> you wrote: > From 1f6aaba856fbf484c442eb33cf220774d57fba8d Mon Sep 17 00:00:00 2001 > From: miaofng > Date: Fri, 23 Oct 2009 17:06:50 +0800 > Subject: [PATCH] [can] add u-boot sja1000/can support > > Signed-off-by: miaofng Please pro

Re: [U-Boot] [PATCH] add u-boot sja1000/can support

2009-10-26 Thread miaofng
It seems there's a big difference between my current project >> and u-boot common usage. I can only enjoy the patch myself now >> >> i want to get a packet from usb/network, then redirect it to can bus. >> So blocked write/read of can is not allowed. >> > > what's wrong with receiving data ove

Re: [U-Boot] [PATCH] add u-boot sja1000/can support

2009-10-26 Thread Wolfgang Grandegger
Hello, miaofng wrote: >>From 1f6aaba856fbf484c442eb33cf220774d57fba8d Mon Sep 17 00:00:00 2001 > From: miaofng > Date: Fri, 23 Oct 2009 17:06:50 +0800 > Subject: [PATCH] [can] add u-boot sja1000/can support There are already CAN controllers supported for some board, e.g. ./tqm5200/cmd_stk52xx.c,

Re: [U-Boot] [PATCH] add u-boot sja1000/can support

2009-10-26 Thread Mike Frysinger
On Monday 26 October 2009 04:30:10 miaofng wrote: > Hi mike, please do not top post > It seems there's a big difference between my current project > and u-boot common usage. I can only enjoy the patch myself now > > i want to get a packet from usb/network, then redirect it to can bus. > So block

Re: [U-Boot] [PATCH] add u-boot sja1000/can support

2009-10-26 Thread Matthias Fuchs
Do we have boards that use this code? Matthias On Saturday 24 October 2009 06:17, miaofng wrote: > >From 1f6aaba856fbf484c442eb33cf220774d57fba8d Mon Sep 17 00:00:00 2001 > From: miaofng > Date: Fri, 23 Oct 2009 17:06:50 +0800 > Subject: [PATCH] [can] add u-boot sja1000/can support > > Signed-o

Re: [U-Boot] [PATCH] add u-boot sja1000/can support

2009-10-26 Thread Mike Frysinger
On Monday 26 October 2009 00:48:39 miaofng wrote: > Thanks for careful review. I'll resend the patch according to your remarks > except follwing: 1) > > > +int register_candev(struct can_device *dev) > > use "can" or "candev", dont mix the two > > answer: register_candev is origin from register

Re: [U-Boot] [PATCH] add u-boot sja1000/can support

2009-10-25 Thread miaofng
Hi Mike, Thanks for your careful review. I'll resend the patch according to your remarks except below: 1) > +int register_candev(struct can_device *dev) use "can" or "candev", dont mix the two answer: register_candev is origin from register_netdev(...). CAN is something like network, it may h

Re: [U-Boot] [PATCH] add u-boot sja1000/can support

2009-10-23 Thread Mike Frysinger
On Saturday 24 October 2009 00:17:50 miaofng wrote: > From 1f6aaba856fbf484c442eb33cf220774d57fba8d Mon Sep 17 00:00:00 2001 > From: miaofng > Date: Fri, 23 Oct 2009 17:06:50 +0800 > Subject: [PATCH] [can] add u-boot sja1000/can support this should be split into two patches -- one for the core CA

[U-Boot] [PATCH] add u-boot sja1000/can support

2009-10-23 Thread miaofng
>From 1f6aaba856fbf484c442eb33cf220774d57fba8d Mon Sep 17 00:00:00 2001 From: miaofng Date: Fri, 23 Oct 2009 17:06:50 +0800 Subject: [PATCH] [can] add u-boot sja1000/can support Signed-off-by: miaofng --- Makefile |1 + drivers/can/Makefile | 46 drivers/can/can_core.