Re: [U-Boot] [PATCH] USB:host: Attribute packed removed from usb structures

2012-03-07 Thread Amit Virdi
On Wed, Mar 7, 2012 at 7:03 PM, Mike Frysinger wrote: > On Wednesday 07 March 2012 03:23:42 Amit Virdi wrote: >> >> I did the changes suggested by you and tested the build. The issue >> >> didn't come up. Then I reverted the code to the original (attributes >> >> retained and ehci directly de-refe

Re: [U-Boot] [PATCH] USB:host: Attribute packed removed from usb structures

2012-03-07 Thread Mike Frysinger
On Wednesday 07 March 2012 03:23:42 Amit Virdi wrote: > >> I did the changes suggested by you and tested the build. The issue > >> didn't come up. Then I reverted the code to the original (attributes > >> retained and ehci directly de-referencing the pointers. The issue didn't > >> come here too. >

Re: [U-Boot] [PATCH] USB:host: Attribute packed removed from usb structures

2012-03-07 Thread Amit Virdi
Dear Marek, On 3/7/2012 5:08 PM, Marek Vasut wrote: Dear Amit Virdi, Dear Marek, I did the changes suggested by you and tested the build. The issue didn't come up. Then I reverted the code to the original (attributes retained and ehci directly de-referencing the pointers. The issue didn't co

Re: [U-Boot] [PATCH] USB:host: Attribute packed removed from usb structures

2012-03-07 Thread Marek Vasut
Dear Amit Virdi, > Dear Marek, > > >> I did the changes suggested by you and tested the build. The issue > >> didn't come up. Then I reverted the code to the original (attributes > >> retained and ehci directly de-referencing the pointers. The issue didn't > >> come here too. > >> > >> Today, I

Re: [U-Boot] [PATCH] USB:host: Attribute packed removed from usb structures

2012-03-07 Thread Amit Virdi
Dear Marek, I did the changes suggested by you and tested the build. The issue didn't come up. Then I reverted the code to the original (attributes retained and ehci directly de-referencing the pointers. The issue didn't come here too. Today, I used armv7-linux-gcc (GCC) v4.6.2 So I suspect the

Re: [U-Boot] [PATCH] USB:host: Attribute packed removed from usb structures

2012-03-07 Thread Amit Virdi
Mike, I did the changes suggested by you and tested the build. The issue didn't come up. Then I reverted the code to the original (attributes retained and ehci directly de-referencing the pointers. The issue didn't come here too. Today, I used armv7-linux-gcc (GCC) v4.6.2 So I suspect there ha

Re: [U-Boot] [PATCH] USB:host: Attribute packed removed from usb structures

2012-03-06 Thread Mike Frysinger
On Tuesday 06 March 2012 07:06:22 Amit Virdi wrote: > On 2/29/2012 3:55 PM, Amit Virdi wrote: > > On 2/28/2012 6:26 AM, Mike Frysinger wrote: > >> On Monday 27 February 2012 15:53:29 Marek Vasut wrote: > On Monday 27 February 2012 08:14:26 Marek Vasut wrote: > >> On 2/25/2012 3:42 PM, Albe

Re: [U-Boot] [PATCH] USB:host: Attribute packed removed from usb structures

2012-03-06 Thread Marek Vasut
Dear Amit Virdi, > Hello Mike and Marek, > > On 2/29/2012 3:55 PM, Amit Virdi wrote: > > Hello Mike, > > > > On 2/28/2012 6:26 AM, Mike Frysinger wrote: > >> On Monday 27 February 2012 15:53:29 Marek Vasut wrote: > On Monday 27 February 2012 08:14:26 Marek Vasut wrote: > >> On 2/25/2012

Re: [U-Boot] [PATCH] USB:host: Attribute packed removed from usb structures

2012-03-06 Thread Amit Virdi
Hello Mike and Marek, On 2/29/2012 3:55 PM, Amit Virdi wrote: Hello Mike, On 2/28/2012 6:26 AM, Mike Frysinger wrote: On Monday 27 February 2012 15:53:29 Marek Vasut wrote: On Monday 27 February 2012 08:14:26 Marek Vasut wrote: On 2/25/2012 3:42 PM, Albert ARIBAUD wrote: Le 24/02/2012 12:58

Re: [U-Boot] [PATCH] USB:host: Attribute packed removed from usb structures

2012-02-29 Thread Amit Virdi
Hello Mike, On 2/28/2012 6:26 AM, Mike Frysinger wrote: On Monday 27 February 2012 15:53:29 Marek Vasut wrote: On Monday 27 February 2012 08:14:26 Marek Vasut wrote: On 2/25/2012 3:42 PM, Albert ARIBAUD wrote: Le 24/02/2012 12:58, Amit Virdi a écrit : Packed attribute is forcing a bytewise w

Re: [U-Boot] [PATCH] USB:host: Attribute packed removed from usb structures

2012-02-27 Thread Mike Frysinger
On Monday 27 February 2012 15:53:29 Marek Vasut wrote: > > On Monday 27 February 2012 08:14:26 Marek Vasut wrote: > > > > On 2/25/2012 3:42 PM, Albert ARIBAUD wrote: > > > > > Le 24/02/2012 12:58, Amit Virdi a écrit : > > > > >> Packed attribute is forcing a bytewise write on device registers, > >

Re: [U-Boot] [PATCH] USB:host: Attribute packed removed from usb structures

2012-02-27 Thread Marek Vasut
> On Monday 27 February 2012 08:14:26 Marek Vasut wrote: > > > On 2/25/2012 3:42 PM, Albert ARIBAUD wrote: > > > > Le 24/02/2012 12:58, Amit Virdi a écrit : > > > >> Packed attribute is forcing a bytewise write on device registers, > > > >> there by, resulting in a misbehavior on gcc-4.4.1. > > > >

Re: [U-Boot] [PATCH] USB:host: Attribute packed removed from usb structures

2012-02-27 Thread Mike Frysinger
On Monday 27 February 2012 08:14:26 Marek Vasut wrote: > > On 2/25/2012 3:42 PM, Albert ARIBAUD wrote: > > > Le 24/02/2012 12:58, Amit Virdi a écrit : > > >> Packed attribute is forcing a bytewise write on device registers, > > >> there by, resulting in a misbehavior on gcc-4.4.1. > > >> Reverting

Re: [U-Boot] [PATCH] USB:host: Attribute packed removed from usb structures

2012-02-27 Thread Mike Frysinger
On Monday 27 February 2012 05:02:14 Amit Virdi wrote: > On 2/25/2012 12:48 AM, Mike Frysinger wrote: > > On Friday 24 February 2012 06:58:40 Amit Virdi wrote: > >> Packed attribute is forcing a bytewise write on device registers, > >> there by, resulting in a misbehavior on gcc-4.4.1. > > > > so u

Re: [U-Boot] [PATCH] USB:host: Attribute packed removed from usb structures

2012-02-27 Thread Marek Vasut
> On 2/25/2012 3:42 PM, Albert ARIBAUD wrote: > > Hi Amit, > > Hello Albert, > > > Le 24/02/2012 12:58, Amit Virdi a écrit : > >> From: Vipin Kumar > >> > >> Packed attribute is forcing a bytewise write on device registers, > >> there by, resulting in a misbehavior on gcc-4.4.1. > >> Reverting t

Re: [U-Boot] [PATCH] USB:host: Attribute packed removed from usb structures

2012-02-27 Thread Amit Virdi
Hello Mike, On 2/25/2012 12:48 AM, Mike Frysinger wrote: On Friday 24 February 2012 06:58:40 Amit Virdi wrote: Packed attribute is forcing a bytewise write on device registers, there by, resulting in a misbehavior on gcc-4.4.1. so use a compiler that isn't broken ? It doesn't seem like comp

Re: [U-Boot] [PATCH] USB:host: Attribute packed removed from usb structures

2012-02-26 Thread Vipin Kumar
On 2/25/2012 3:42 PM, Albert ARIBAUD wrote: Hi Amit, Hello Albert, Le 24/02/2012 12:58, Amit Virdi a écrit : From: Vipin Kumar Packed attribute is forcing a bytewise write on device registers, there by, resulting in a misbehavior on gcc-4.4.1. Reverting the structures to non-packed If (j

Re: [U-Boot] [PATCH] USB:host: Attribute packed removed from usb structures

2012-02-25 Thread Albert ARIBAUD
Hi Amit, Le 24/02/2012 12:58, Amit Virdi a écrit : From: Vipin Kumar Packed attribute is forcing a bytewise write on device registers, there by, resulting in a misbehavior on gcc-4.4.1. Reverting the structures to non-packed If (just asking, not asserting) the issue is caused by fields being

Re: [U-Boot] [PATCH] USB:host: Attribute packed removed from usb structures

2012-02-24 Thread Mike Frysinger
On Friday 24 February 2012 06:58:40 Amit Virdi wrote: > Packed attribute is forcing a bytewise write on device registers, > there by, resulting in a misbehavior on gcc-4.4.1. so use a compiler that isn't broken ? -mike signature.asc Description: This is a digitally signed message part. _

[U-Boot] [PATCH] USB:host: Attribute packed removed from usb structures

2012-02-24 Thread Amit Virdi
From: Vipin Kumar Packed attribute is forcing a bytewise write on device registers, there by, resulting in a misbehavior on gcc-4.4.1. Reverting the structures to non-packed Signed-off-by: Vipin Kumar Signed-off-by: Amit Virdi --- drivers/usb/host/ehci.h |4 ++-- 1 files changed, 2 insert