Re: [U-Boot] [PATCH] SPI: cmd_spi.c: add option to specify bus and mode

2010-08-25 Thread Reinhard Meyer
Dear Mike Frysinger, >> :[.] > > how so ? the bus:cs.mode field is always going to be one argv, and your patch > has it so that argv[1] is always parsed against this form. i dont see where > this limitation is that you're seeing ... > -mike Currently, without a ":", the "." part won't be handle

Re: [U-Boot] [PATCH] SPI: cmd_spi.c: add option to specify bus and mode

2010-08-25 Thread Mike Frysinger
On Tuesday, August 24, 2010 06:53:49 Reinhard Meyer wrote: > > this usage string no longer makes sense. how about: > > "[:][.] - Send bits from > > out the SPI\n" > > The problem is, that without blowing up the parser even more, only > 2 forms of the command are valid: > > the classic form >

Re: [U-Boot] [PATCH] SPI: cmd_spi.c: add option to specify bus and mode

2010-08-24 Thread Mike Frysinger
On Tuesday, August 24, 2010 04:05:19 Reinhard Meyer wrote: > Dear Mike Frysinger, > > were you going to send an updated version ? > > Soon. Currently I have other issues and a rather > "dirty" working tree :) dont sweat it. just wanted to make sure it wasnt lost/forgotten/ignored. -mike signat

Re: [U-Boot] [PATCH] SPI: cmd_spi.c: add option to specify bus and mode

2010-08-24 Thread Reinhard Meyer
Dear Mike Frysinger, > this usage string no longer makes sense. how about: > "[:][.] - Send bits from > out the SPI\n" The problem is, that without blowing up the parser even more, only 2 forms of the command are valid: the classic form or :[.] Since this command is mainly used for

Re: [U-Boot] [PATCH] SPI: cmd_spi.c: add option to specify bus and mode

2010-08-24 Thread Reinhard Meyer
Dear Mike Frysinger, > were you going to send an updated version ? Soon. Currently I have other issues and a rather "dirty" working tree :) Reinhard ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] SPI: cmd_spi.c: add option to specify bus and mode

2010-08-23 Thread Mike Frysinger
were you going to send an updated version ? -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] SPI: cmd_spi.c: add option to specify bus and mode

2010-08-09 Thread Mike Frysinger
On Mon, Aug 9, 2010 at 12:21 PM, Reinhard Meyer wrote: > @@ -107,15 +119,13 @@ int do_spi (cmd_tbl_t *cmdtp, int flag, int argc, char > * const argv[]) >                return 1; >        } > > -       /* FIXME: Make these parameters run-time configurable */ > -       slave = spi_setup_slave(CONFI

[U-Boot] [PATCH] SPI: cmd_spi.c: add option to specify bus and mode

2010-08-09 Thread Reinhard Meyer
To facilitate better testing of SPI peripherals, add the possibility to specify bus and SPI mode to the "sspi" command Signed-off-by: Reinhard Meyer --- common/cmd_spi.c | 33 +++-- 1 files changed, 23 insertions(+), 10 deletions(-) diff --git a/common/cmd_spi.c b/