qiang.z...@freescale.com wrote:
T1040QDS has microcode for Fman and another microcode for QE.
The two microcodes is different.
QE microcode is needed.
Then why do you have an #else statement:
+#ifdef CONFIG_PPC_T1040
+ qe_upload_firmware((const void *)CONFIG_SYS_QE_UCODE_FW_ADDR);
+#els
Timur Tabi wrote:
> -Original Message-
> From: Timur Tabi [mailto:ti...@tabi.org]
> Sent: Sunday, January 26, 2014 12:37 PM
> To: Zhao Qiang-B45475
> Cc: U-Boot Mailing List; Xu Jiucheng-B37781; Xie Xiaobo-R63061
> Subject: Re: [U-Boot] [PATCH] Powerpc/QE: Add QE
Timur Tabi wrote:
> -Original Message-
> From: Timur Tabi [mailto:ti...@tabi.org]
> Sent: Sunday, January 26, 2014 11:23 AM
> To: Zhao Qiang-B45475
> Cc: U-Boot Mailing List; Xu Jiucheng-B37781; Xie Xiaobo-R63061
> Subject: Re: [U-Boot] [PATCH] Powerpc/QE: Add QE
e: [U-Boot] [PATCH] Powerpc/QE: Add QE support for T1040
>
> On Fri, Jan 24, 2014 at 3:05 AM, Zhao Qiang wrote:
> > +#ifdef CONFIG_PPC_T1040
> > + qe_upload_firmware((const void *)CONFIG_SYS_QE_UCODE_FW_ADDR);
> > +#else
> > qe_upload_firmware((const
qiang.z...@freescale.com wrote:
Other boards have either Fman or QE, So CONFIG_SYS_QE_FMAN_FW_ADDR can
be used either Fman or QE.
But T1040QDS have both Fman and QE.
Does the T1040QDS have microcode for both Fman and QE? Normally, QE
microcode is not needed.
qiang.z...@freescale.com wrote:
CONFIG_SYS_QE_FMAN_FW_ADDR is used for Fman microcode while
CONFIG_SYS_QE_UCODE_FW_ADDR used
For QE microcode.
No, CONFIG_SYS_QE_FMAN_FW_ADDR is used for both QE and Fman microcode.
That's why it says "QE_FMAN" in it. This is documented in the README.
___
On Fri, Jan 24, 2014 at 3:05 AM, Zhao Qiang wrote:
> +#ifdef CONFIG_PPC_T1040
> + qe_upload_firmware((const void *)CONFIG_SYS_QE_UCODE_FW_ADDR);
> +#else
> qe_upload_firmware((const void *)CONFIG_SYS_QE_FMAN_FW_ADDR);
> +#endif
>
It's been a while since I looked at the QE code in U
T1040 has QE-related addresses different from other boards,
modify those addresses value with macro CONFIG_PPC_T1040
and CONFIG_T1040QDS.
Add function qe_board_setup to mux the bus to tdm or uart
according to hwconfig.
Signed-off-by: Jiucheng Xu
Signed-off-by: Zhao Qiang
---
arch/powerpc/cpu/mp
8 matches
Mail list logo
