Re: [U-Boot] [PATCH] PMIC: MAX77686: fix invalid bus check

2014-06-23 Thread Minkyu Kang
On 19/06/14 05:13, Jeroen Hofstee wrote: > Since p->bus is unsigned checking for negative values > is optimized away. Since bus is already used as an argument > use tmp. While at it, don't declare variables in the middle > of a function. > > cc: Rajeshwari Shinde > Signed-off-by: Jeroen Hofstee

[U-Boot] [PATCH] PMIC: MAX77686: fix invalid bus check

2014-06-18 Thread Jeroen Hofstee
Since p->bus is unsigned checking for negative values is optimized away. Since bus is already used as an argument use tmp. While at it, don't declare variables in the middle of a function. cc: Rajeshwari Shinde Signed-off-by: Jeroen Hofstee --- drivers/power/pmic/pmic_max77686.c | 13 --