On 04.09.2010 00:14, Mike Frysinger wrote:
> On Friday, September 03, 2010 17:23:43 Reinhard Meyer wrote:
>> On 03.09.2010 23:03, Mike Frysinger wrote:
not sure, however, if calling spi_setup_slave() is ok at this point.
>>>
>>> i believe the func should only doing validation on the arguments.
On Friday, September 03, 2010 17:23:43 Reinhard Meyer wrote:
> On 03.09.2010 23:03, Mike Frysinger wrote:
> >> not sure, however, if calling spi_setup_slave() is ok at this point.
> >
> > i believe the func should only doing validation on the arguments. it
> > shouldnt need to talk to any actual
On 03.09.2010 23:03, Mike Frysinger wrote:
>> not sure, however, if calling spi_setup_slave() is ok at this point.
>
> i believe the func should only doing validation on the arguments. it shouldnt
> need to talk to any actual hardware. maybe this needs codifying in the API
> documentation.
In atm
On Friday, September 03, 2010 16:31:47 Reinhard Meyer wrote:
> int enc_initialize(int bus, int cs, int speed)
should take the same parameters (including type) as spi_setup_slave
> eth_register(&(enc->netdev));
no need for the () before the &
> not sure, however, if calling spi_setup_slave
On 03.09.2010 21:51, Mike Frysinger wrote:
> yes and no. the spi bus/cs/mode/speed is established at initialize() time,
> not init(), so you'd need to store that per-instance information somewhere.
> and how the discussion about netconsole handling falls out (not calling
> init/halt after every tr
On Friday, September 03, 2010 13:50:28 Reinhard Meyer wrote:
> Something like this?
yes
> I agree that's more perfect but kind of overkill, too;
> assuming that only one enc can be active at any given time;)
yes and no. the spi bus/cs/mode/speed is established at initialize() time,
not init(),
Dear Mike Frysinger,
> pass the bus/cs/speed/mode in to the initialize function and store it in the
> per-device state. then you can work fine with multiple enc28j60 devices in
> one board.
>
> along those lines, all of the local enc funcs should be changed to take the
> private state and operate
On Thursday, August 26, 2010 02:41:56 Reinhard Meyer wrote:
> From: Reinhard Meyer
> >>
> >> Give me a tip how I can change that info. The first patch to this was
> >> committed while I used. Squashing other patches into it does not
> >> change that. rebase -i, edit, --amend does not present
Dear Mike Frysinger,
From: Reinhard Meyer
>>
>> Give me a tip how I can change that info. The first patch to this was
>> committed while I used. Squashing other patches into it does not
>> change that. rebase -i, edit, --amend does not present that line for
>> edit. The only idea I have now is
On Thursday, August 26, 2010 02:19:07 Reinhard Meyer wrote:
> >> From: Reinhard Meyer
>
> Give me a tip how I can change that info. The first patch to this was
> committed while I used . Squashing other patches into it does not
> change that. rebase -i, edit, --amend does not present that line for
Dear Mike Frysinger,
>> From: Reinhard Meyer
Give me a tip how I can change that info. The first patch to this was
committed while I used . Squashing other patches into it does not
change that. rebase -i, edit, --amend does not present that line for
edit. The only idea I have now is making an empt
On Wednesday, August 25, 2010 08:47:39 Reinhard Meyer wrote:
> From: Reinhard Meyer
>
> Signed-off-by: Reinhard Meyer
these two fields should match (e-mail)
also, this patch seems to depend on some other change not in mainline or Ben's
net tree ...
> +#include
> +#include
the common.h hea
From: Reinhard Meyer
Signed-off-by: Reinhard Meyer
---
drivers/net/Makefile |1 +
drivers/net/enc28j60.c | 650
drivers/net/enc28j60.h | 217
include/netdev.h |1 +
4 files changed, 869 insertions(+), 0 deletion
13 matches
Mail list logo
