Re: [U-Boot] [PATCH] Makefile: use $(shell ...) for determining file_size

2014-07-25 Thread Simon Glass
Hi Chris, On 24 July 2014 06:14, Chris Packham wrote: > Hi Simon, > > On Wed, Jul 23, 2014 at 10:27 PM, Simon Glass wrote: >> On 22 July 2014 18:08, Chris Packham wrote: >>> file_size was being calculated using back-ticks but map_size uses >>> $(shell ...). Update the file_size calculation to u

Re: [U-Boot] [PATCH] Makefile: use $(shell ...) for determining file_size

2014-07-23 Thread Chris Packham
Hi Simon, On Wed, Jul 23, 2014 at 10:27 PM, Simon Glass wrote: > On 22 July 2014 18:08, Chris Packham wrote: >> file_size was being calculated using back-ticks but map_size uses >> $(shell ...). Update the file_size calculation to use $(shell ...). >> >> Signed-off-by: Chris Packham > > Acked-b

Re: [U-Boot] [PATCH] Makefile: use $(shell ...) for determining file_size

2014-07-23 Thread Tom Rini
On Wed, Jul 23, 2014 at 09:24:00PM +0200, Jeroen Hofstee wrote: > Hi, > > On 23-07-14 20:03, Tom Rini wrote: > >On Wed, Jul 23, 2014 at 04:27:36AM -0600, Simon Glass wrote: > >>On 22 July 2014 18:08, Chris Packham wrote: > >>>file_size was being calculated using back-ticks but map_size uses > >>>

Re: [U-Boot] [PATCH] Makefile: use $(shell ...) for determining file_size

2014-07-23 Thread Jeroen Hofstee
Hi, On 23-07-14 20:03, Tom Rini wrote: On Wed, Jul 23, 2014 at 04:27:36AM -0600, Simon Glass wrote: On 22 July 2014 18:08, Chris Packham wrote: file_size was being calculated using back-ticks but map_size uses $(shell ...). Update the file_size calculation to use $(shell ...). Signed-off-by:

Re: [U-Boot] [PATCH] Makefile: use $(shell ...) for determining file_size

2014-07-23 Thread Tom Rini
On Wed, Jul 23, 2014 at 04:27:36AM -0600, Simon Glass wrote: > On 22 July 2014 18:08, Chris Packham wrote: > > file_size was being calculated using back-ticks but map_size uses > > $(shell ...). Update the file_size calculation to use $(shell ...). > > > > Signed-off-by: Chris Packham > > Acked-

Re: [U-Boot] [PATCH] Makefile: use $(shell ...) for determining file_size

2014-07-23 Thread Simon Glass
On 22 July 2014 18:08, Chris Packham wrote: > file_size was being calculated using back-ticks but map_size uses > $(shell ...). Update the file_size calculation to use $(shell ...). > > Signed-off-by: Chris Packham Acked-by: Simon Glass But you might want to look at this. http://patchwork.ozl

[U-Boot] [PATCH] Makefile: use $(shell ...) for determining file_size

2014-07-22 Thread Chris Packham
file_size was being calculated using back-ticks but map_size uses $(shell ...). Update the file_size calculation to use $(shell ...). Signed-off-by: Chris Packham --- The back ticks didn't work in my environment (GNU Make 3.81). Updating to use $(shell ...) makes sense from a consistency view eve