Re: [U-Boot] [PATCH] Loop block device for sandbox

2012-08-31 Thread Marek Vasut
Dear Pavel Herrmann, > On Friday 31 of August 2012 18:02:22 Marek Vasut wrote: > > > > > > > > > > > + memcpy(pdev->product, filenames[dev], namelen); > > > > > > > > > > > + pdev->product[20] = 0; > > > > > > > > > > > + > > > > > > > > > > > + if (fd != -1) { > > > > > > > > > > > > > > > > > >

Re: [U-Boot] [PATCH] Loop block device for sandbox

2012-08-31 Thread Pavel Herrmann
On Friday 31 of August 2012 18:02:22 Marek Vasut wrote: > > > > > > > > > > + memcpy(pdev->product, filenames[dev], namelen); > > > > > > > > > > + pdev->product[20] = 0; > > > > > > > > > > + > > > > > > > > > > + if (fd != -1) { > > > > > > > > > > > > > > > > > > And if "fd" is -1 ? > > >

Re: [U-Boot] [PATCH] Loop block device for sandbox

2012-08-31 Thread Marek Vasut
Dear Pavel Herrmann, > On Friday 31 of August 2012 14:57:41 Marek Vasut wrote: > > > > > > > > > +lbaint_t sata_read(int dev, lbaint_t start, lbaint_t > > > > > > > > > blkcnt, void *buffer) > > > > > > > > > +{ > > > > > > > > > + block_dev_desc_t *pdev = &(sata_dev_desc[dev]); > > > > > > >

Re: [U-Boot] [PATCH] Loop block device for sandbox

2012-08-31 Thread Pavel Herrmann
On Friday 31 of August 2012 14:57:41 Marek Vasut wrote: > > > > > > > > +lbaint_t sata_read(int dev, lbaint_t start, lbaint_t blkcnt, > > > > > > > > void *buffer) > > > > > > > > +{ > > > > > > > > + block_dev_desc_t *pdev = &(sata_dev_desc[dev]); > > > > > > > > + int fd = (long) pdev

Re: [U-Boot] [PATCH] Loop block device for sandbox

2012-08-31 Thread Marek Vasut
Dear Pavel Herrmann, > On Thursday 30 August 2012 23:53:58 Marek Vasut wrote: > > Dear Pavel Herrmann, > > > > > On Thursday 30 of August 2012 20:45:13 Marek Vasut wrote: > > > > Dear Pavel Herrmann, > > > > > > > > > On Thursday 30 of August 2012 00:18:18 Marek Vasut wrote: > > > > > ...snip...

Re: [U-Boot] [PATCH] Loop block device for sandbox

2012-08-31 Thread Pavel Herrmann
On Thursday 30 August 2012 23:53:58 Marek Vasut wrote: > Dear Pavel Herrmann, > > > On Thursday 30 of August 2012 20:45:13 Marek Vasut wrote: > > > Dear Pavel Herrmann, > > > > > > > On Thursday 30 of August 2012 00:18:18 Marek Vasut wrote: > > > > ...snip... > > > > > > > > > > +extern block_de

Re: [U-Boot] [PATCH] Loop block device for sandbox

2012-08-30 Thread Marek Vasut
Dear Pavel Herrmann, > On Thursday 30 of August 2012 20:45:13 Marek Vasut wrote: > > Dear Pavel Herrmann, > > > > > On Thursday 30 of August 2012 00:18:18 Marek Vasut wrote: > > > ...snip... > > > > > > > > +extern block_dev_desc_t sata_dev_desc[]; > > > > > + > > > > > +int init_sata(int dev) >

Re: [U-Boot] [PATCH] Loop block device for sandbox

2012-08-30 Thread Pavel Herrmann
On Thursday 30 of August 2012 20:45:13 Marek Vasut wrote: > Dear Pavel Herrmann, > > > On Thursday 30 of August 2012 00:18:18 Marek Vasut wrote: > > ...snip... > > > > > > +extern block_dev_desc_t sata_dev_desc[]; > > > > + > > > > +int init_sata(int dev) > > > > +{ > > > > + block_dev_desc

Re: [U-Boot] [PATCH] Loop block device for sandbox

2012-08-30 Thread Marek Vasut
Dear Pavel Herrmann, > On Thursday 30 of August 2012 00:18:18 Marek Vasut wrote: > ...snip... > > > > +extern block_dev_desc_t sata_dev_desc[]; > > > + > > > +int init_sata(int dev) > > > +{ > > > + block_dev_desc_t *pdev = &(sata_dev_desc[dev]); > > > > Superfluous braces ... Actually, I think

Re: [U-Boot] [PATCH] Loop block device for sandbox

2012-08-30 Thread Pavel Herrmann
On Thursday 30 of August 2012 00:18:18 Marek Vasut wrote: ...snip... > > +extern block_dev_desc_t sata_dev_desc[]; > > + > > +int init_sata(int dev) > > +{ > > + block_dev_desc_t *pdev = &(sata_dev_desc[dev]); > > Superfluous braces ... Actually, I think sata_dev_desc as it would work very > wel

Re: [U-Boot] [PATCH] Loop block device for sandbox

2012-08-29 Thread Marek Vasut
Dear Pavel Herrmann, > This driver uses files as block devices, can be used for testing disk > operations on sandbox. Port count and filenames are set in board config. > > Signed-off-by: Pavel Herrmann > CC: Marek Vasut > --- > drivers/block/Makefile| 1 + > drivers/block/loop.c | 1

Re: [U-Boot] [PATCH] Loop block device for sandbox

2012-08-29 Thread Pavel Herrmann
More CC On Wednesday 29 August 2012 17:46:43 Pavel Herrmann wrote: > This driver uses files as block devices, can be used for testing disk > operations on sandbox. Port count and filenames are set in board config. > > Signed-off-by: Pavel Herrmann > CC: Marek Vasut > --- > drivers/block/Makefi

[U-Boot] [PATCH] Loop block device for sandbox

2012-08-29 Thread Pavel Herrmann
This driver uses files as block devices, can be used for testing disk operations on sandbox. Port count and filenames are set in board config. Signed-off-by: Pavel Herrmann CC: Marek Vasut --- drivers/block/Makefile| 1 + drivers/block/loop.c | 107 +++