Re: [U-Boot] [PATCH] IXP425: Improving print_cpuinfo code Part 1/1

On 23:28 Tue 16 Dec , Stefan Althoefer wrote: > Jean-Christophe PLAGNIOL-VILLARD schrieb: > >> + cfg_clk = *IXP425_EXP_CFG0 >> 21; > > please use readx/writex > > The pointer dereference style is used throughout the > other files in the IXP port as well. Shouldn't this > be handled the same

Re: [U-Boot] [PATCH] IXP425: Improving print_cpuinfo code Part 1/1

Jean-Christophe PLAGNIOL-VILLARD schrieb: >> +cfg_clk = *IXP425_EXP_CFG0 >> 21; > please use readx/writex The pointer dereference style is used throughout the other files in the IXP port as well. Shouldn't this be handled the same way in all files? >> >> +/* FIXME: is there any need fo

Re: [U-Boot] [PATCH] IXP425: Improving print_cpuinfo code Part 1/1

On 22:09 Thu 04 Dec , Stefan Althoefer wrote: > [PATCH] IXP425: Improving print_cpuinfo code > > The existing version of print_cpuinfo did read the > processor ID and detects clock speed from this. > > This is not correct, as the IXP425 has the ability > to "downgrade" clock speed by using st

[U-Boot] [PATCH] IXP425: Improving print_cpuinfo code Part 1/1

[PATCH] IXP425: Improving print_cpuinfo code The existing version of print_cpuinfo did read the processor ID and detects clock speed from this. This is not correct, as the IXP425 has the ability to "downgrade" clock speed by using strapping resistors. The improved code reads strapping informatio