Re: [U-Boot] [PATCH] Fix debug output.

2009-12-08 Thread Wolfgang Denk
Dear Thomas Weber, In message <4b1eb952.1070...@gmx.li> you wrote: > > should I resend the better formatted patch with a proper subject line > and a more detailed comment? How to name the patch? [Patch V2] ? 2 x yes, please. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH,

Re: [U-Boot] [PATCH] Fix debug output.

2009-12-08 Thread Thomas Weber
Wolfgang Denk schrieb: > Dear Thomas Weber, > > In message <4b1cfef3.7080...@corscience.de> you wrote: > >>> Which problem is this supposed to fix? >>> > ... > >> In commit 60f61e6d7655400bb785a2ef637581679941f6d1 the following calls >> where changed. >> >> - DM9000_DMP_PACKET("

Re: [U-Boot] [PATCH] Fix debug output.

2009-12-07 Thread Wolfgang Denk
Dear Thomas Weber, In message <4b1cfef3.7080...@corscience.de> you wrote: > > > Which problem is this supposed to fix? ... > In commit 60f61e6d7655400bb785a2ef637581679941f6d1 the following calls > where changed. > > - DM9000_DMP_PACKET("eth_send", packet, length); > + DM9000_DMP_PACK

Re: [U-Boot] [PATCH] Fix debug output.

2009-12-07 Thread Thomas Weber
Wolfgang Denk schrieb: > Dear Thomas Weber, > > In message <1260177679-18337-1-git-send-email-we...@corscience.de> you wrote: > >> Signed-off-by: Thomas Weber >> --- >> drivers/net/dm9000x.c |4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/dm9000x

Re: [U-Boot] [PATCH] Fix debug output.

2009-12-07 Thread Wolfgang Denk
Dear Thomas Weber, In message <4b1ce6a5.3080...@corscience.de> you wrote: > > should i resend the patch with the corrected subject line? No, because it needs other fixes (and explanations) anyway. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zu

Re: [U-Boot] [PATCH] Fix debug output.

2009-12-07 Thread Wolfgang Denk
Dear Thomas Weber, In message <1260177679-18337-1-git-send-email-we...@corscience.de> you wrote: > Signed-off-by: Thomas Weber > --- > drivers/net/dm9000x.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/dm9000x.c b/drivers/net/dm9000x.c > index 73d

Re: [U-Boot] [PATCH] Fix debug output.

2009-12-07 Thread Thomas Weber
Mike Frysinger schrieb: > your subject line really needs a prefix to narrow down where exactly your fix > is going. it also should not have a period. > > net: dm9000x: fix debug output > -mike > Hello, should i resend the patch with the corrected subject line? Thomas signature.asc Descrip

Re: [U-Boot] [PATCH] Fix debug output.

2009-12-07 Thread Mike Frysinger
your subject line really needs a prefix to narrow down where exactly your fix is going. it also should not have a period. net: dm9000x: fix debug output -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list

[U-Boot] [PATCH] Fix debug output.

2009-12-07 Thread Thomas Weber
Signed-off-by: Thomas Weber --- drivers/net/dm9000x.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/dm9000x.c b/drivers/net/dm9000x.c index 73dd335..08bd794 100644 --- a/drivers/net/dm9000x.c +++ b/drivers/net/dm9000x.c @@ -74,8 +74,8 @@ TODO: external MI