Re: [U-Boot] [PATCH] Fix bootdelay timeout calculation when SYS_HZ!=1000

2013-03-21 Thread Wolfgang Denk
Dear Stephen Warren, In message <514b2f8e.2090...@wwwdotorg.org> you wrote: > > Then why does the config option still exist; surely it should be > removed, or defined somewhere other than the per-board config file? Removing it requires work, including testing efforts... Best regards, Wolfgang D

Re: [U-Boot] [PATCH] Fix bootdelay timeout calculation when SYS_HZ!=1000

2013-03-21 Thread Tom Rini
On Thu, Mar 21, 2013 at 01:07:18PM -0500, Jon Hunter wrote: > > On 03/21/2013 10:28 AM, Tom Rini wrote: > > -BEGIN PGP SIGNED MESSAGE- > > Hash: SHA1 > > > > On 03/21/2013 11:25 AM, Jon Hunter wrote: > >> > >> On 03/21/2013 09:41 AM, Tom Rini wrote: > >>> On Thu, Mar 21, 2013 at 03:35:40P

Re: [U-Boot] [PATCH] Fix bootdelay timeout calculation when SYS_HZ!=1000

2013-03-21 Thread Jon Hunter
On 03/21/2013 10:28 AM, Tom Rini wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 03/21/2013 11:25 AM, Jon Hunter wrote: >> >> On 03/21/2013 09:41 AM, Tom Rini wrote: >>> On Thu, Mar 21, 2013 at 03:35:40PM +0100, Wolfgang Denk wrote: Dear Tom, In message <514b1036.30

Re: [U-Boot] [PATCH] Fix bootdelay timeout calculation when SYS_HZ!=1000

2013-03-21 Thread Stephen Warren
On 03/21/2013 12:55 AM, Wolfgang Denk wrote: > Dear Stephen Warren, > > In message <1363842874-8286-1-git-send-email-swar...@wwwdotorg.org> you wrote: >> Commit b2f3e0e "console: USB: KBD: Fix incorrect autoboot timeout" >> re-wrote the bootdelay timeout loop. However, it hard-coded the value >> t

Re: [U-Boot] [PATCH] Fix bootdelay timeout calculation when SYS_HZ!=1000

2013-03-21 Thread Tom Rini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/21/2013 11:25 AM, Jon Hunter wrote: > > On 03/21/2013 09:41 AM, Tom Rini wrote: >> On Thu, Mar 21, 2013 at 03:35:40PM +0100, Wolfgang Denk wrote: >>> Dear Tom, >>> >>> In message <514b1036.3090...@ti.com> you wrote: > A system with CO

Re: [U-Boot] [PATCH] Fix bootdelay timeout calculation when SYS_HZ!=1000

2013-03-21 Thread Jon Hunter
On 03/21/2013 09:41 AM, Tom Rini wrote: > On Thu, Mar 21, 2013 at 03:35:40PM +0100, Wolfgang Denk wrote: >> Dear Tom, >> >> In message <514b1036.3090...@ti.com> you wrote: >>> A system with CONFIG_SYS_HZ != 1000 is _broken_. >>> >>> So, RPi is going higher, and Jon hit this on I suspect omap2

Re: [U-Boot] [PATCH] Fix bootdelay timeout calculation when SYS_HZ!=1000

2013-03-21 Thread Tom Rini
On Thu, Mar 21, 2013 at 03:35:40PM +0100, Wolfgang Denk wrote: > Dear Tom, > > In message <514b1036.3090...@ti.com> you wrote: > > > > > A system with CONFIG_SYS_HZ != 1000 is _broken_. > > > > So, RPi is going higher, and Jon hit this on I suspect omap2420h4 > > which is also higher (after mathi

Re: [U-Boot] [PATCH] Fix bootdelay timeout calculation when SYS_HZ!=1000

2013-03-21 Thread Wolfgang Denk
Dear Tom, In message <514b1036.3090...@ti.com> you wrote: > > > A system with CONFIG_SYS_HZ != 1000 is _broken_. > > So, RPi is going higher, and Jon hit this on I suspect omap2420h4 > which is also higher (after mathing that all out). If we no longer > support CONFIG_SYS_HZ != 1000 we need to m

Re: [U-Boot] [PATCH] Fix bootdelay timeout calculation when SYS_HZ!=1000

2013-03-21 Thread Tom Rini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/21/2013 02:55 AM, Wolfgang Denk wrote: > Dear Stephen Warren, > > In message <1363842874-8286-1-git-send-email-swar...@wwwdotorg.org> > you wrote: >> Commit b2f3e0e "console: USB: KBD: Fix incorrect autoboot >> timeout" re-wrote the bootdelay ti

Re: [U-Boot] [PATCH] Fix bootdelay timeout calculation when SYS_HZ!=1000

2013-03-20 Thread Wolfgang Denk
Dear Stephen Warren, In message <1363842874-8286-1-git-send-email-swar...@wwwdotorg.org> you wrote: > Commit b2f3e0e "console: USB: KBD: Fix incorrect autoboot timeout" > re-wrote the bootdelay timeout loop. However, it hard-coded the value > that get_delay() was expected to increment in one secon

[U-Boot] [PATCH] Fix bootdelay timeout calculation when SYS_HZ!=1000

2013-03-20 Thread Stephen Warren
Commit b2f3e0e "console: USB: KBD: Fix incorrect autoboot timeout" re-wrote the bootdelay timeout loop. However, it hard-coded the value that get_delay() was expected to increment in one second, rather than calculating it based on CONFIG_SYS_HZ. On systems where SYS_HZ != 1000, this caused bootdela