Re: [U-Boot] [PATCH] Fix CFI flash driver for 8-bit bus support

2011-04-12 Thread Stefan Roese
Hi Aaron, On Tuesday 12 April 2011 10:33:05 Aaron Williams wrote: > It looks like the other reset is not needed. Good. Then please remove it from your patch and resend a new version labled "v2" [PATCH v2]. And please include the patch revision history as mentioned by Albert. See this link for d

Re: [U-Boot] [PATCH] Fix CFI flash driver for 8-bit bus support

2011-04-12 Thread Aaron Williams
Hi Stefan, It looks like the other reset is not needed. The delay is needed. Without it sometimes the reset would fail on some of our boards. Here's what Garret Swalling at Spansion told me: ... The CFI reset calls into two subroutines that resove to: flash_write_cmd(info, 0, 0, AMD_CMD

Re: [U-Boot] [PATCH] Fix CFI flash driver for 8-bit bus support

2011-04-12 Thread Stefan Roese
Hi Aaron, On Tuesday 12 April 2011 09:46:22 Aaron Williams wrote: > I believe this is correct. Hmmm, I'm still not convinced about this reset call in the erase function. Do you really need it for the CFI driver to work correctly on your board? Could you please test without this reset command?

Re: [U-Boot] [PATCH] Fix CFI flash driver for 8-bit bus support

2011-04-12 Thread Aaron Williams
I believe this is correct. I have redone the patch as two patches. The first patch fixes the 8-bit addressing and has been tested with both 8 and 16-bit support with Spansion. The second patch adds a 1us delay after every reset call. In my email correspondence with Spansion they said that at le

Re: [U-Boot] [PATCH] Fix CFI flash driver for 8-bit bus support

2011-04-04 Thread Stefan Roese
Hi Aaron, On Saturday 02 April 2011 09:17:01 Aaron Williams wrote: > This patch corrects the addresses used when working with Spansion/AMD FLASH > chips. Addressing for 8 and 16 bits is almost identical except in the > 16-bit case the LSB of the address is always 0. The confusion arose > because

Re: [U-Boot] [PATCH] Fix CFI flash driver for 8-bit bus support

2011-04-02 Thread Rogan Dawes
On 2011/04/02 1:23 PM, Albert ARIBAUD wrote: > Hi Aaron, > > Le 02/04/2011 09:17, Aaron Williams a écrit : >> This patch corrects the addresses used when working with Spansion/AMD FLASH >> chips. >> Addressing for 8 and 16 bits is almost identical except in the 16-bit case >> the >> LSB of the a

Re: [U-Boot] [PATCH] Fix CFI flash driver for 8-bit bus support

2011-04-02 Thread Albert ARIBAUD
Hi Aaron, Le 02/04/2011 09:17, Aaron Williams a écrit : > This patch corrects the addresses used when working with Spansion/AMD FLASH > chips. > Addressing for 8 and 16 bits is almost identical except in the 16-bit case the > LSB of the address is always 0. The confusion arose because the addres

[U-Boot] [PATCH] Fix CFI flash driver for 8-bit bus support

2011-04-02 Thread Aaron Williams
This patch corrects the addresses used when working with Spansion/AMD FLASH chips. Addressing for 8 and 16 bits is almost identical except in the 16-bit case the LSB of the address is always 0. The confusion arose because the addresses in the datasheet for 16-bit mode are word addresses but this