Re: [U-Boot] [PATCH] FAT: Properly align buffers to allow cache operations

2012-04-10 Thread Eric Nelson
On 04/10/2012 01:34 PM, Wolfgang Denk wrote: Dear Dirk, In message<4f845db6.7050...@googlemail.com> you wrote: Sorry guys, but I'm confused now. Heh. Me too ;-) We have two patches, Eric's [1] and Marek's [2]. Which one should we take? With the discussion here and [3] I'm somehow under t

Re: [U-Boot] [PATCH] FAT: Properly align buffers to allow cache operations

2012-04-10 Thread Wolfgang Denk
Dear Dirk, In message <4f845db6.7050...@googlemail.com> you wrote: > > Sorry guys, but I'm confused now. Heh. Me too ;-) > We have two patches, Eric's [1] and Marek's [2]. Which one should we > take? With the discussion here and [3] I'm somehow under the > impression that both patches [1] [2]

Re: [U-Boot] [PATCH] FAT: Properly align buffers to allow cache operations

2012-04-10 Thread Dirk Behme
On 10.04.2012 17:07, Eric Nelson wrote: On 04/09/2012 10:00 PM, Marek Vasut wrote: Dear Mike Frysinger, On Monday 09 April 2012 02:45:03 Marek Vasut wrote: @@ -765,9 +767,6 @@ -__attribute__ ((__aligned__ (__alignof__ (dir_entry -__u8 do_fat_read_block[MAX_CLUSTSIZE]; - @@ -788,6 +787,7

Re: [U-Boot] [PATCH] FAT: Properly align buffers to allow cache operations

2012-04-10 Thread Eric Nelson
On 04/09/2012 10:00 PM, Marek Vasut wrote: Dear Mike Frysinger, On Monday 09 April 2012 02:45:03 Marek Vasut wrote: @@ -765,9 +767,6 @@ -__attribute__ ((__aligned__ (__alignof__ (dir_entry -__u8 do_fat_read_block[MAX_CLUSTSIZE]; - @@ -788,6 +787,7 @@ do_fat_read (const char *filename, vo

Re: [U-Boot] [PATCH] FAT: Properly align buffers to allow cache operations

2012-04-09 Thread Marek Vasut
Dear Mike Frysinger, > On Monday 09 April 2012 02:45:03 Marek Vasut wrote: > > @@ -765,9 +767,6 @@ > > > > -__attribute__ ((__aligned__ (__alignof__ (dir_entry > > -__u8 do_fat_read_block[MAX_CLUSTSIZE]; > > - > > > > @@ -788,6 +787,7 @@ do_fat_read (const char *filename, void *buffer, > >

Re: [U-Boot] [PATCH] FAT: Properly align buffers to allow cache operations

2012-04-09 Thread Mike Frysinger
On Monday 09 April 2012 02:45:03 Marek Vasut wrote: > @@ -765,9 +767,6 @@ > > -__attribute__ ((__aligned__ (__alignof__ (dir_entry > -__u8 do_fat_read_block[MAX_CLUSTSIZE]; > - > > @@ -788,6 +787,7 @@ do_fat_read (const char *filename, void *buffer, > > int rootdir_size = 0; > int

Re: [U-Boot] [PATCH] FAT: Properly align buffers to allow cache operations

2012-04-09 Thread Eric Nelson
On 04/09/2012 01:26 AM, Marek Vasut wrote: Dear Dirk Behme, On 09.04.2012 08:45, Marek Vasut wrote: Align the FAT FS buffers so DMA on various systems can directly pick them. Just fyi: http://lists.denx.de/pipermail/u-boot/2012-March/119311.html http://lists.denx.de/pipermail/u-boot/2012-M

Re: [U-Boot] [PATCH] FAT: Properly align buffers to allow cache operations

2012-04-09 Thread Marek Vasut
Dear Dirk Behme, > On 09.04.2012 10:26, Marek Vasut wrote: > > Dear Dirk Behme, > > > >> On 09.04.2012 08:45, Marek Vasut wrote: > >>> Align the FAT FS buffers so DMA on various systems can directly pick > >>> them. > >> > >> Just fyi: > >> > >> http://lists.denx.de/pipermail/u-boot/2012-March/

Re: [U-Boot] [PATCH] FAT: Properly align buffers to allow cache operations

2012-04-09 Thread Dirk Behme
On 09.04.2012 10:26, Marek Vasut wrote: Dear Dirk Behme, On 09.04.2012 08:45, Marek Vasut wrote: Align the FAT FS buffers so DMA on various systems can directly pick them. Just fyi: http://lists.denx.de/pipermail/u-boot/2012-March/119311.html http://lists.denx.de/pipermail/u-boot/2012-Marc

Re: [U-Boot] [PATCH] FAT: Properly align buffers to allow cache operations

2012-04-09 Thread Marek Vasut
Dear Dirk Behme, > On 09.04.2012 08:45, Marek Vasut wrote: > > Align the FAT FS buffers so DMA on various systems can directly pick > > them. > > Just fyi: > > http://lists.denx.de/pipermail/u-boot/2012-March/119311.html > > http://lists.denx.de/pipermail/u-boot/2012-March/119309.html Heh, nic

Re: [U-Boot] [PATCH] FAT: Properly align buffers to allow cache operations

2012-04-09 Thread Dirk Behme
On 09.04.2012 08:45, Marek Vasut wrote: Align the FAT FS buffers so DMA on various systems can directly pick them. Just fyi: http://lists.denx.de/pipermail/u-boot/2012-March/119311.html http://lists.denx.de/pipermail/u-boot/2012-March/119309.html Best regards Dirk Signed-off-by: Marek Vas

[U-Boot] [PATCH] FAT: Properly align buffers to allow cache operations

2012-04-08 Thread Marek Vasut
Align the FAT FS buffers so DMA on various systems can directly pick them. Signed-off-by: Marek Vasut --- fs/fat/fat.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/fs/fat/fat.c b/fs/fat/fat.c index 1f95eb4..d709e59 100644 --- a/fs/fat/fat.c +++ b/fs/fat/fat