Re: [U-Boot] [PATCH] Disaligned buffer in print_buffer

2010-08-28 Thread Reinhard Meyer
Dear Albert ARIBAUD, >> If you need a patch for this, I have made the change here this morning. >> I can format and email one instantly. >> >> Reinhard > > I say go ahead! Its there, right after the message. It has a different title, because I made it before I found the tread about the issue :) Re

Re: [U-Boot] [PATCH] Disaligned buffer in print_buffer

2010-08-27 Thread Albert ARIBAUD
Le 27/08/2010 21:06, Reinhard Meyer a écrit : > On 27.08.2010 20:24, Stefano Babic wrote: >> Reinhard Meyer wrote: >> >> Hi Reinhard, >> >>> Why not just declare it as >>> uint_32t linebuf[MAX_LINE_LENGTH_BYTES/4+1]; >>> ? >> >> Yes, we do not need any special compiler attribute. I forward to Alber

Re: [U-Boot] [PATCH] Disaligned buffer in print_buffer

2010-08-27 Thread Reinhard Meyer
On 27.08.2010 20:24, Stefano Babic wrote: > Reinhard Meyer wrote: > > Hi Reinhard, > >> Why not just declare it as >> uint_32t linebuf[MAX_LINE_LENGTH_BYTES/4+1]; >> ? > > Yes, we do not need any special compiler attribute. I forward to Albert, > he sent previously an analog patch to solve thi

Re: [U-Boot] [PATCH] Disaligned buffer in print_buffer

2010-08-27 Thread Stefano Babic
Reinhard Meyer wrote: Hi Reinhard, > Why not just declare it as > uint_32t linebuf[MAX_LINE_LENGTH_BYTES/4+1]; > ? Yes, we do not need any special compiler attribute. I forward to Albert, he sent previously an analog patch to solve this issue. Stefano --

Re: [U-Boot] [PATCH] Disaligned buffer in print_buffer

2010-08-27 Thread Mike Frysinger
On Friday, August 27, 2010 05:41:08 Reinhard Meyer wrote: > Stefano Babic schrieb: > > --- a/lib/display_options.c > > +++ b/lib/display_options.c > > @@ -101,7 +101,7 @@ void print_size(unsigned long long size, const char > > *s) > > > > #define DEFAULT_LINE_LENGTH_BYTES (16) > > int print_buff

Re: [U-Boot] [PATCH] Disaligned buffer in print_buffer

2010-08-27 Thread Reinhard Meyer
Stefano Babic schrieb: > As linebuf is accessed with 32-bit pointers, its address > must be 32 bit aligned to avoid misaligned access. > > Signed-off-by: Stefano Babic > --- > lib/display_options.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/lib/display_option

Re: [U-Boot] [PATCH] Disaligned buffer in print_buffer

2010-08-20 Thread Albert ARIBAUD
Le 19/08/2010 18:33, Stefano Babic a écrit : > As I see in the > discussion, the patch proposed is accepted because > _attribute__((__aligned__())) is everywhere used in u-boot. > > Stefano 'Acceptable' is my bet... Not yet 'accepted' though. :) Amicalement, -- Albert. __

Re: [U-Boot] [PATCH] Disaligned buffer in print_buffer

2010-08-19 Thread Stefano Babic
Mike Frysinger wrote: > On Thursday, August 19, 2010 07:01:58 Stefano Babic wrote: >> -uint8_t linebuf[MAX_LINE_LENGTH_BYTES + 1]; >> +uint8_t linebuf[MAX_LINE_LENGTH_BYTES + 1] >> __attribute__((__aligned__(4))); > > i'd rather we go with Albert Aribaud's change (posted 14 Aug 2010) > -mi

Re: [U-Boot] [PATCH] Disaligned buffer in print_buffer

2010-08-19 Thread Mike Frysinger
On Thursday, August 19, 2010 07:01:58 Stefano Babic wrote: > - uint8_t linebuf[MAX_LINE_LENGTH_BYTES + 1]; > + uint8_t linebuf[MAX_LINE_LENGTH_BYTES + 1] > __attribute__((__aligned__(4))); i'd rather we go with Albert Aribaud's change (posted 14 Aug 2010) -mike signature.asc Description:

[U-Boot] [PATCH] Disaligned buffer in print_buffer

2010-08-19 Thread Stefano Babic
As linebuf is accessed with 32-bit pointers, its address must be 32 bit aligned to avoid misaligned access. Signed-off-by: Stefano Babic --- lib/display_options.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/display_options.c b/lib/display_options.c index 20319e6