Re: [U-Boot] [PATCH] Davinci: add a pin multiplexer configuration API

2009-10-30 Thread Kim Phillips
On Fri, 30 Oct 2009 15:17:40 + "Thompson, Nick (GE EntSol, Intelligent Platforms)" wrote: > > From: Kim Phillips [mailto:kim.phill...@freescale.com] > Sent: 30 October 2009 14:57 > > On Fri, 30 Oct 2009 09:26:12 +0100 > > Wolfgang Denk wrote: > > > > > Dear Kim Phillips, > > > > > > In me

Re: [U-Boot] [PATCH] Davinci: add a pin multiplexer configuration API

2009-10-30 Thread Thompson, Nick (GE EntSol, Intelligent Platforms)
From: Kim Phillips [mailto:kim.phill...@freescale.com] Sent: 30 October 2009 14:57 > On Fri, 30 Oct 2009 09:26:12 +0100 > Wolfgang Denk wrote: > > > Dear Kim Phillips, > > > > In message <20091029182304.469c9f7f.kim.phill...@freescale.com> you wrote: > > > if (field < PIN_MUX_NUM_FIELDS && > > >

Re: [U-Boot] [PATCH] Davinci: add a pin multiplexer configuration API

2009-10-30 Thread Kim Phillips
On Fri, 30 Oct 2009 09:26:12 +0100 Wolfgang Denk wrote: > Dear Kim Phillips, > > In message <20091029182304.469c9f7f.kim.phill...@freescale.com> you wrote: > > if (field < PIN_MUX_NUM_FIELDS && > > (value & ~PIN_MUX_FIELD_MASK) == 0) { > > > > > + int offset = field * PIN_MU

Re: [U-Boot] [PATCH] Davinci: add a pin multiplexer configuration API

2009-10-30 Thread Wolfgang Denk
Dear Kim Phillips, In message <20091029182304.469c9f7f.kim.phill...@freescale.com> you wrote: > > > + if (field < PIN_MUX_NUM_FIELDS && > > + (value & ~PIN_MUX_FIELD_MASK) == 0) { > > the second line should not be indented as though it is the code > subblock; it should

Re: [U-Boot] [PATCH] Davinci: add a pin multiplexer configuration API

2009-10-29 Thread Kim Phillips
On Thu, 29 Oct 2009 15:38:18 + Nick Thompson wrote: > +int davinci_configure_pin_mux(const struct pinmux_config *pins, int n_pins) > +{ > + int i; > + > + for (i = 0; i < n_pins; i++) { > + int value = pins[i].value; > + int field = pins[i].field; > + > +

[U-Boot] [PATCH] Davinci: add a pin multiplexer configuration API

2009-10-29 Thread Nick Thompson
Davinci: add a pin multiplexer configuration API. Creates a method allowing pin settings to be logically grouped into data structure arrays and provids an API to configure the PINMUX settings to enable the relevant pin functions. Signed-off-by: Nick Thompson --- Applies to: u-boot-ti The PINMUX