Re: [U-Boot] [PATCH] CRITICAL error in v2013.04-rc2 (true and false not working)

2013-04-04 Thread York Sun
On 04/04/2013 02:50 PM, Wolfgang Denk wrote: > Dear York, > > In message <515df125.8060...@freescale.com> you wrote: >> >> Wolfgang, shall we change U_BOOT_CMD to take string instead of >> stringifying or use the local undef? > > I tend to prefer Pali Rohar's fix. > I sent out two fixes. No str

Re: [U-Boot] [PATCH] CRITICAL error in v2013.04-rc2 (true and false not working)

2013-04-04 Thread Wolfgang Denk
Dear York, In message <515df125.8060...@freescale.com> you wrote: > > Wolfgang, shall we change U_BOOT_CMD to take string instead of > stringifying or use the local undef? I tend to prefer Pali Rohar's fix. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk &

Re: [U-Boot] [PATCH] CRITICAL error in v2013.04-rc2 (true and false not working)

2013-04-04 Thread York Sun
On 04/04/2013 02:47 PM, Wolfgang Denk wrote: > Dear York Sun, > > In message <515deed2.90...@freescale.com> you wrote: >> >> Would this fix be acceptable? > > No... > >> +#ifdef true >> +#undef true >> +#undef false >> + >> U_BOOT_CMD( >> false, CONFIG_SYS_MAXARGS, 1, do_false

Re: [U-Boot] [PATCH] CRITICAL error in v2013.04-rc2 (true and false not working)

2013-04-04 Thread Wolfgang Denk
Dear York Sun, In message <515deed2.90...@freescale.com> you wrote: > > Would this fix be acceptable? No... > +#ifdef true > +#undef true > +#undef false > + > U_BOOT_CMD( > false, CONFIG_SYS_MAXARGS, 1, do_false, > "do nothing, unsuccessfully", > @@ -171,3 +175,5 @@ U

Re: [U-Boot] [PATCH] CRITICAL error in v2013.04-rc2 (true and false not working)

2013-04-04 Thread Tom Rini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/04/2013 05:05 PM, York Sun wrote: > On 04/04/2013 01:33 PM, Wolfgang Denk wrote: >> Dear Pali Rohár, >> >> In message <201304041946.55455@pali> you wrote: >>> >>> u-boot "true" and "false" hush commands are copiled >>> incorrectly in uboot v201

Re: [U-Boot] [PATCH] CRITICAL error in v2013.04-rc2 (true and false not working)

2013-04-04 Thread York Sun
On 04/04/2013 02:26 PM, Pali Rohár wrote: > On Thursday 04 April 2013 23:21:22 York Sun wrote: >> On 04/04/2013 02:19 PM, Pali Rohár wrote: >>> On Thursday 04 April 2013 23:05:18 York Sun wrote: On 04/04/2013 01:33 PM, Wolfgang Denk wrote: > Dear Pali Rohár, > > In message <2013040

Re: [U-Boot] [PATCH] CRITICAL error in v2013.04-rc2 (true and false not working)

2013-04-04 Thread Pali Rohár
On Thursday 04 April 2013 23:21:22 York Sun wrote: > On 04/04/2013 02:19 PM, Pali Rohár wrote: > > On Thursday 04 April 2013 23:05:18 York Sun wrote: > >> On 04/04/2013 01:33 PM, Wolfgang Denk wrote: > >>> Dear Pali Rohár, > >>> > >>> In message <201304041946.55455@pali> you wrote: > u-boot "

Re: [U-Boot] [PATCH] CRITICAL error in v2013.04-rc2 (true and false not working)

2013-04-04 Thread York Sun
On 04/04/2013 02:19 PM, Pali Rohár wrote: > On Thursday 04 April 2013 23:05:18 York Sun wrote: >> On 04/04/2013 01:33 PM, Wolfgang Denk wrote: >>> Dear Pali Rohár, >>> >>> In message <201304041946.55455@pali> you wrote: u-boot "true" and "false" hush commands are copiled incorrectly in ub

Re: [U-Boot] [PATCH] CRITICAL error in v2013.04-rc2 (true and false not working)

2013-04-04 Thread Pali Rohár
On Thursday 04 April 2013 23:05:18 York Sun wrote: > On 04/04/2013 01:33 PM, Wolfgang Denk wrote: > > Dear Pali Rohár, > > > > In message <201304041946.55455@pali> you wrote: > >> u-boot "true" and "false" hush commands are copiled > >> incorrectly in uboot v2013.04-rc2 > >> (c8142633e169665b24635

Re: [U-Boot] [PATCH] CRITICAL error in v2013.04-rc2 (true and false not working)

2013-04-04 Thread York Sun
On 04/04/2013 01:33 PM, Wolfgang Denk wrote: > Dear Pali Rohár, > > In message <201304041946.55455@pali> you wrote: >> >> u-boot "true" and "false" hush commands are copiled incorrectly in uboot >> v2013.04-rc2 >> (c8142633e169665b246352918df5b76fd243bb71) >> >> when I run help in u-boot it show

Re: [U-Boot] [PATCH] CRITICAL error in v2013.04-rc2 (true and false not working)

2013-04-04 Thread York Sun
On 04/04/2013 01:33 PM, Wolfgang Denk wrote: > Dear Pali Rohár, > > In message <201304041946.55455@pali> you wrote: >> >> u-boot "true" and "false" hush commands are copiled incorrectly in uboot >> v2013.04-rc2 >> (c8142633e169665b246352918df5b76fd243bb71) >> >> when I run help in u-boot it show

Re: [U-Boot] [PATCH] CRITICAL error in v2013.04-rc2 (true and false not working)

2013-04-04 Thread Wolfgang Denk
Dear Pali Rohár, In message <201304041946.55455@pali> you wrote: > > u-boot "true" and "false" hush commands are copiled incorrectly in uboot > v2013.04-rc2 > (c8142633e169665b246352918df5b76fd243bb71) > > when I run help in u-boot it show: > > # help > 0 - do nothing, unsuccessfully > 1

[U-Boot] [PATCH] CRITICAL error in v2013.04-rc2 (true and false not working)

2013-04-04 Thread Pali Rohár
Hello, with this version of gcc which is default in ubuntu 12.10: $ arm-linux-gnueabi-gcc -v Using built-in specs. COLLECT_GCC=arm-linux-gnueabi-gcc COLLECT_LTO_WRAPPER=/usr/lib/gcc/arm-linux-gnueabi/4.7/lto-wrapper Target: arm-linux-gnueabi Configured with: ../src/configure -v --with-pkgversion=