Re: [U-Boot] [PATCH] Bugfix: mpc512x_fec MII accesses fail after ethernet transfers

2009-07-23 Thread Wolfgang Denk
Dear Thomas Dörfler, In message <4a637b05.4030...@embedded-brains.de> you wrote: > > But I doubt that (re-)calling mpc512x_fec_init_phy before a MII command > is run is really a good idea. Using the same code for initial init and > repeated init makes sense, but this function in its current > impl

Re: [U-Boot] [PATCH] Bugfix: mpc512x_fec MII accesses fail after ethernet transfers

2009-07-21 Thread Ben Warren
Wolfgang Denk wrote: > Dear Ben Warren, > > In message <4a6565d4.7050...@gmail.com> you wrote: > >> Thomas Dörfler wrote: >> >>> The mpc512x FEC network driver resets the FEC before transferring >>> packets. With this reset, the FEC clears the previous setting of MII >>> transfer speed. Thi

Re: [U-Boot] [PATCH] Bugfix: mpc512x_fec MII accesses fail after ethernet transfers

2009-07-21 Thread Ben Warren
Wolfgang Denk wrote: > Dear Ben Warren, > > In message <4a6565d4.7050...@gmail.com> you wrote: > >> Thomas Dörfler wrote: >> >>> The mpc512x FEC network driver resets the FEC before transferring >>> packets. With this reset, the FEC clears the previous setting of MII >>> transfer speed. Thi

Re: [U-Boot] [PATCH] Bugfix: mpc512x_fec MII accesses fail after ethernet transfers

2009-07-21 Thread Wolfgang Denk
Dear Ben Warren, In message <4a6565d4.7050...@gmail.com> you wrote: > > Thomas Dörfler wrote: > > The mpc512x FEC network driver resets the FEC before transferring > > packets. With this reset, the FEC clears the previous setting of MII > > transfer speed. This patch ensures, that it is set again

Re: [U-Boot] [PATCH] Bugfix: mpc512x_fec MII accesses fail after ethernet transfers

2009-07-20 Thread Ben Warren
Thomas, Thomas Dörfler wrote: > The mpc512x FEC network driver resets the FEC before transferring > packets. With this reset, the FEC clears the previous setting of MII > transfer speed. This patch ensures, that it is set again to a reasonable > value after a FEC reset. > > Signed-off-by: Thomas D

Re: [U-Boot] [PATCH] Bugfix: mpc512x_fec MII accesses fail after ethernet transfers

2009-07-19 Thread Thomas Dörfler
Hello, thank you for your feedback. Sorry for the "newbie" problems, I should have checked this before sending the patch. But I doubt that (re-)calling mpc512x_fec_init_phy before a MII command is run is really a good idea. Using the same code for initial init and repeated init makes sense, but t

Re: [U-Boot] [PATCH] Bugfix: mpc512x_fec MII accesses fail after ethernet transfers

2009-07-19 Thread Wolfgang Denk
Dear =?ISO-8859-15?Q?Thomas_D=F6rfler?=, In message <4a633d5a.3060...@embedded-brains.de> you wrote: > The mpc512x FEC network driver resets the FEC before transferring > packets. With this reset, the FEC clears the previous setting of MII > transfer speed. This patch ensures, that it is set again

Re: [U-Boot] [PATCH] Bugfix: mpc512x_fec MII accesses fail after ethernet transfers

2009-07-19 Thread Wolfgang Denk
Dear =?ISO-8859-1?Q?Thomas_D=F6rfler?=, In message <4a635d1f.9030...@embedded-brains.de> you wrote: > > on our custom MPC5121 board I used the following sequence to see the bug: > > - After U-Boot stated, I could inspect the status of the PHY with "mii > info". This works fine even if repeated.

Re: [U-Boot] [PATCH] Bugfix: mpc512x_fec MII accesses fail after ethernet transfers

2009-07-19 Thread Thomas Dörfler
Hello, on our custom MPC5121 board I used the following sequence to see the bug: - After U-Boot stated, I could inspect the status of the PHY with "mii info". This works fine even if repeated. - then I trigger some network activity, for example with "ping" - if I try to get the PHY status with

Re: [U-Boot] [PATCH] Bugfix: mpc512x_fec MII accesses fail after ethernet transfers

2009-07-19 Thread Wolfgang Denk
Dear =?ISO-8859-15?Q?Thomas_D=F6rfler?=, In message <4a633d5a.3060...@embedded-brains.de> you wrote: > The mpc512x FEC network driver resets the FEC before transferring > packets. With this reset, the FEC clears the previous setting of MII > transfer speed. This patch ensures, that it is set again

[U-Boot] [PATCH] Bugfix: mpc512x_fec MII accesses fail after ethernet transfers

2009-07-19 Thread Thomas Dörfler
The mpc512x FEC network driver resets the FEC before transferring packets. With this reset, the FEC clears the previous setting of MII transfer speed. This patch ensures, that it is set again to a reasonable value after a FEC reset. Signed-off-by: Thomas Doerfler -- diff --git a/drivers/net/mpc51