Re: [U-Boot] [PATCH] Blackfin: br4: new board port

2012-01-08 Thread Mike Frysinger
On Monday 28 November 2011 10:33:39 Wolfgang Denk wrote: > Dimitar Penev wrote: > > >> > > +#define CONFIG_TFTP_BLOCKSIZE 4404 > ... > > > I have to admit that I'm not sure i having the last ine is a clever > > > idea, but in any case it's not my problem. > > > > I have not dug in the code to unde

Re: [U-Boot] [PATCH] Blackfin: br4: new board port

2011-11-28 Thread Dimitar Penev
Dear Wolfgang Denk Dear "Dimitar Penev", In message <003601ccada7$ce75c4b0$2901a8c0@dpn> you wrote: I will try to fix my mail client and use plain text as it is explained for the future. You don't even need to fix your mail client. Just use "git send-email". Thank you for the tip. I hav

Re: [U-Boot] [PATCH] Blackfin: br4: new board port

2011-11-28 Thread Wolfgang Denk
Dear "Dimitar Penev", In message <001301ccadc3$30140c70$2901a8c0@dpn> you wrote: > > >> > > +#define CONFIG_TFTP_BLOCKSIZE 4404 ... > > I have to admit that I'm not sure i having the last ine is a clever > > idea, but in any case it's not my problem. > > I have not dug in the code to understand

Re: [U-Boot] [PATCH] Blackfin: br4: new board port

2011-11-28 Thread Wolfgang Denk
Dear "Dimitar Penev", In message <003601ccada7$ce75c4b0$2901a8c0@dpn> you wrote: > > I will try to fix my mail client and use plain text as it is explained for > the future. You don't even need to fix your mail client. Just use "git send-email". Best regards, Wolfgang Denk -- DENX Software

Re: [U-Boot] [PATCH] Blackfin: br4: new board port

2011-11-28 Thread Dimitar Penev
Dear Wolfgang Denk, Dear Mike Frysinger, > > +#define CONFIG_HOSTNAME br4 > > +#define CONFIG_IPADDR 192.168.1.100 > > +#define CONFIG_GATEWAYIP 192.168.1.1 > > +#define CONFIG_SERVERIP 192.168.1.2 > > +#define CONFIG_TFTP_BLOCKSIZE 4404 > > NAK. i'm guessing you're only NAK-ing the middle

Re: [U-Boot] [PATCH] Blackfin: br4: new board port

2011-11-28 Thread Dimitar Penev
Dear Wolfgang Denk, Signed-off-by: Dimitar Penev Cc: Mike Frysinger www.switchfin.org/patches/uBoot-br4-v1.patch If you want to submit a patch, then please follow the rules explained for example here: http://www.denx.de/wiki/U-Boot/Patches Most of all, send the patch to the mailing list.

Re: [U-Boot] [PATCH] Blackfin: br4: new board port

2011-11-27 Thread Wolfgang Denk
Dear Mike Frysinger, In message <20271500.49624.vap...@gentoo.org> you wrote: > > > > +#ifndef __ADSPBF534__ > > > +#define ADI_CMDS_NETWORK 1 > > > +#define CONFIG_BFIN_MAC > > > +#define CONFIG_NETCONSOLE1 > > > > These #defines should have no values. > > i'll send a global cleanup

Re: [U-Boot] [PATCH] Blackfin: br4: new board port

2011-11-27 Thread Mike Frysinger
On Sunday 27 November 2011 09:56:20 Wolfgang Denk wrote: > Mike Frysinger wrote: > > +#ifndef __ADSPBF534__ > > +#define ADI_CMDS_NETWORK 1 > > +#define CONFIG_BFIN_MAC > > +#define CONFIG_NETCONSOLE 1 > > These #defines should have no values. i'll send a global cleanup patch for all the Black

Re: [U-Boot] [PATCH] Blackfin: br4: new board port

2011-11-27 Thread Wolfgang Denk
Dear Mike Frysinger, In message <20251614.47433.vap...@gentoo.org> you wrote: > i tweaked a few things (like disabling the CONFIG_ETHADDR). same question for > this board ... where is the MAC normally stored ? > > updated patch is below > -mike > > From 6ff79ef55cb414b0dfb08b8aa9db2baf88495

Re: [U-Boot] [PATCH] Blackfin: br4: new board port

2011-11-27 Thread Wolfgang Denk
Dear Mike Frysinger, In message <20251614.47433.vap...@gentoo.org> you wrote: > i tweaked a few things (like disabling the CONFIG_ETHADDR). same question for > this board ... where is the MAC normally stored ? > > updated patch is below > -mike > > From 6ff79ef55cb414b0dfb08b8aa9db2baf88495

Re: [U-Boot] [PATCH] Blackfin: br4: new board port

2011-11-27 Thread Wolfgang Denk
Dear "Dimitar Penev", In message <00b501ccab98$93f86510$2901a8c0@dpn> you wrote: > > The following patch adds BR4 Appliance support in u-boot. > It is quad channels ISDN BRI board based on Blackfin BF537 CPU > > The patch is based on u-boot-2011R1-RC3 from the ADI u-boot git repository > It is p

Re: [U-Boot] [PATCH] Blackfin: br4: new board port

2011-11-26 Thread Dimitar Penev
Hi Mike, i tweaked a few things (like disabling the CONFIG_ETHADDR). same question for this board ... where is the MAC normally stored ? The MAC for both PR1 and BR4 Appliance boards is only kept in the u-boot environment (variable 'ethaddr') updated patch is below Thank you. Opps indeed

Re: [U-Boot] [PATCH] Blackfin: br4: new board port

2011-11-25 Thread Mike Frysinger
i tweaked a few things (like disabling the CONFIG_ETHADDR). same question for this board ... where is the MAC normally stored ? updated patch is below -mike >From 6ff79ef55cb414b0dfb08b8aa9db2baf8849545b Mon Sep 17 00:00:00 2001 From: Dimitar Penev Date: Fri, 25 Nov 2011 16:05:54 -0500 Subject:

[U-Boot] [PATCH] Blackfin: br4: new board port

2011-11-25 Thread Dimitar Penev
Hi Guys, The following patch adds BR4 Appliance support in u-boot. It is quad channels ISDN BRI board based on Blackfin BF537 CPU The patch is based on u-boot-2011R1-RC3 from the ADI u-boot git repository It is pretty similar as the PR1 Appliance patch I have suggested recently. My email client