Re: [U-Boot] [PATCH] Align end of bss by 4 bytes,

2008-11-18 Thread Wolfgang Denk
Dear Selvamuthukumar, In message <[EMAIL PROTECTED]> you wrote: > > >> If you could do that, it would be a great help. Thanks in advance! > > > > Do you have any such patch in the works? > > > > http://lists.denx.de/pipermail/u-boot/2008-October/041893.html Thanks for the link. Strange, that me

[U-Boot] [PATCH] Align end of bss by 4 bytes

2008-11-01 Thread Selvamuthukumar
Wolfgang, > Most of the bss initialization loop increments 4 bytes > at a time. And the loop end is checked for an 'equal' > condition. Make the bss end address aligned by 4, so > that the loop will end as expected. Any update about this patch? -- Selvamuthukumar ___

Re: [U-Boot] [PATCH] Align end of bss by 4 bytes,

2008-10-27 Thread Selvamuthukumar
On Tue, Oct 28, 2008 at 5:19 AM, Wolfgang Denk <[EMAIL PROTECTED]> wrote: > Dear Selvamuthukumar, > > In message <[EMAIL PROTECTED]> I wrote: >> >> > > Should we not perform this change globally, i. e. to *all* linker >> > > scripts? >> > >> > Do you expect a patch that touches all linker scrip

Re: [U-Boot] [PATCH] Align end of bss by 4 bytes,

2008-10-27 Thread Wolfgang Denk
Dear Selvamuthukumar, In message <[EMAIL PROTECTED]> I wrote: > > > > Should we not perform this change globally, i. e. to *all* linker > > > scripts? > > > > Do you expect a patch that touches all linker scripts, that does not do > > bss alignment? If so, I'll send it. > > If you could do

Re: [U-Boot] [PATCH] Align end of bss by 4 bytes.

2008-10-15 Thread Selvamuthukumar
Trent Piepho, On Thu, Oct 16, 2008 at 4:09 AM, Trent Piepho <[EMAIL PROTECTED]> wrote: > commit 42ed33ffe135f618680f9d6e9712eb35a85bcb62 > Author: Anatolij Gustschin <[EMAIL PROTECTED]> > Date: Wed Dec 5 17:43:20 2007 +0100 > > Fix ppc4xx clear_bss() code > > ppc4xx clear_bss() fails i

Re: [U-Boot] [PATCH] Align end of bss by 4 bytes.

2008-10-15 Thread Trent Piepho
On Thu, 16 Oct 2008, Selvamuthukumar wrote: > Most of the bss initialization loop increments 4 bytes > at a time. And the loop end is checked for an 'equal' > condition. Make the bss end address aligned by 4, so > that the loop will end as expected. It's not really the end of bss that matters, but

Re: [U-Boot] [PATCH] Align end of bss by 4 bytes.

2008-10-15 Thread Graeme Russ
On Thu, Oct 16, 2008 at 7:54 AM, Dan Malek <[EMAIL PROTECTED]> wrote: > > On Oct 15, 2008, at 1:17 PM, Selvamuthukumar wrote: > >> Most of the bss initialization loop increments 4 bytes >> at a time. And the loop end is checked for an 'equal' >> condition. Make the bss end address aligned by 4, so

Re: [U-Boot] [PATCH] Align end of bss by 4 bytes.

2008-10-15 Thread Dan Malek
On Oct 15, 2008, at 1:17 PM, Selvamuthukumar wrote: > Most of the bss initialization loop increments 4 bytes > at a time. And the loop end is checked for an 'equal' > condition. Make the bss end address aligned by 4, so > that the loop will end as expected. IMHO, this is a bad programming practi

Re: [U-Boot] [PATCH] Align end of bss by 4 bytes,

2008-10-15 Thread Wolfgang Denk
Dear Selvamuthukumar, In message <[EMAIL PROTECTED]> you wrote: > > > Should we not perform this change globally, i. e. to *all* linker > > scripts? > > Do you expect a patch that touches all linker scripts, that does not do > bss alignment? If so, I'll send it. If you could do that, it woul

Re: [U-Boot] [PATCH] Align end of bss by 4 bytes,

2008-10-14 Thread Selvamuthukumar
Wolfgang Denk, On Wed, Oct 15, 2008 at 2:28 AM, Wolfgang Denk <[EMAIL PROTECTED]> wrote: > I think this is a problem that may hit probably all architectures & > all boards. > > Should we not perform this change globally, i. e. to *all* linker > scripts? > Do you expect a patch that touches al

Re: [U-Boot] [PATCH] Align end of bss by 4 bytes,

2008-10-14 Thread Wolfgang Denk
Dear Selvamuthukumar, In message <[EMAIL PROTECTED]> you wrote: > bss initialization loop increments 4 bytes at a time. > And the loop end is checked for an 'equal' condition. > Make the bss end address aligned by 4, so that the loop > will end as expected. I think this is a problem that may hit

Re: [U-Boot] [PATCH] Align end of bss by 4 bytes,

2008-10-07 Thread Kumar Gala
> > Size of bss is 6c9d bytes. > > Signed-off-by: Selvamuthukumar <[EMAIL PROTECTED]> Ack. Saw similar issues on 85xx. - k > > --- > cpu/mpc83xx/u-boot.lds |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/cpu/mpc83xx/u-boot.lds b/cpu/mpc83xx/u-boot.lds > index 99ad67

[U-Boot] [PATCH] Align end of bss by 4 bytes,

2008-10-06 Thread Selvamuthukumar
bss initialization loop increments 4 bytes at a time. And the loop end is checked for an 'equal' condition. Make the bss end address aligned by 4, so that the loop will end as expected. Adding below lines creates bss of size not aligned to 4 bytes. typedef struct bss_test__ { unsigned cha

Re: [U-Boot] [PATCH] Align end of bss by 4 bytes,

2008-10-06 Thread Kim Phillips
On Mon, 6 Oct 2008 21:12:58 +0530 Selvamuthukumar <[EMAIL PROTECTED]> wrote: > bss initialization loop increments 4 bytes at a time. > And the loop end is checked for an 'equal' condition. > Make the bss end address aligned by 4, so that the loop > will end as expected. > --- I need a signed-off-

[U-Boot] [PATCH] Align end of bss by 4 bytes,

2008-10-06 Thread Selvamuthukumar
bss initialization loop increments 4 bytes at a time. And the loop end is checked for an 'equal' condition. Make the bss end address aligned by 4, so that the loop will end as expected. --- cpu/mpc83xx/u-boot.lds |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/cpu/mpc83xx/