Re: [U-Boot] [PATCH] Add splash screen support via loading from flash

2013-06-04 Thread Stefano Babic
Hi Robert, On 04/06/2013 16:57, Robert Winkler wrote: > Yes, as Eric mentioned I submitted a patch yesterday which fixes > splash screen prepare not working > with CONFIG_VIDEO and will submit a separate patch to add the function > to nitrogen6x.c once that goes through. Ok, understood. > > Th

Re: [U-Boot] [PATCH] Add splash screen support via loading from flash

2013-06-04 Thread Stefano Babic
Hi Eric, On 04/06/2013 16:30, Eric Nelson wrote: > Gotcha. This method doesn't involve splash_screen_prepare() though. > > It also will blink the display since the splash screen will paint > after the the compiled-in logo case. > http://git.denx.de/u-boot.git/?p=u-boot.git;a=blob;f=common/lc

Re: [U-Boot] [PATCH] Add splash screen support via loading from flash

2013-06-04 Thread Robert Winkler
Stefano On Tue, Jun 4, 2013 at 7:30 AM, Eric Nelson wrote: > Hi Stefano, > > > On 06/04/2013 07:15 AM, Stefano Babic wrote: >> >> Hi Eric, >> >> On 04/06/2013 15:55, Eric Nelson wrote: >>> >>> Hi Stefano, >>> >>> On 06/04/2013 06:44 AM, Stefano Babic wrote: Hi Robert, On 03/06

Re: [U-Boot] [PATCH] Add splash screen support via loading from flash

2013-06-04 Thread Eric Nelson
Hi Stefano, On 06/04/2013 07:15 AM, Stefano Babic wrote: Hi Eric, On 04/06/2013 15:55, Eric Nelson wrote: Hi Stefano, On 06/04/2013 06:44 AM, Stefano Babic wrote: Hi Robert, On 03/06/2013 18:34, Robert Winkler wrote: Which is the advantage instead of using the "preboot" variable setting C

Re: [U-Boot] [PATCH] Add splash screen support via loading from flash

2013-06-04 Thread Stefano Babic
Hi Eric, On 04/06/2013 15:55, Eric Nelson wrote: > Hi Stefano, > > On 06/04/2013 06:44 AM, Stefano Babic wrote: >> Hi Robert, >> >> On 03/06/2013 18:34, Robert Winkler wrote: >> Which is the advantage instead of using the "preboot" variable setting CONFIG_PREBOOT ? It does pretty the s

Re: [U-Boot] [PATCH] Add splash screen support via loading from flash

2013-06-04 Thread Eric Nelson
Hi Stefano, On 06/04/2013 06:44 AM, Stefano Babic wrote: Hi Robert, On 03/06/2013 18:34, Robert Winkler wrote: Which is the advantage instead of using the "preboot" variable setting CONFIG_PREBOOT ? It does pretty the same and you can move the whole script outside of board code. The preboot

Re: [U-Boot] [PATCH] Add splash screen support via loading from flash

2013-06-04 Thread Stefano Babic
Hi Robert, On 03/06/2013 18:34, Robert Winkler wrote: >> Which is the advantage instead of using the "preboot" variable setting >> CONFIG_PREBOOT ? It does pretty the same and you can move the whole >> script outside of board code. > > The preboot command is run too late. It looks like it is ru

Re: [U-Boot] [PATCH] Add splash screen support via loading from flash

2013-06-03 Thread Robert Winkler
Hello Stefano On Mon, Jun 3, 2013 at 12:44 AM, Stefano Babic wrote: > Hi Robert, > > > On 30/05/2013 23:03, Robert Winkler wrote: >> Signed-off-by: Robert Winkler >> --- >> board/boundary/nitrogen6x/nitrogen6x.c | 22 ++ >> include/configs/nitrogen6x.h | 11 +++

Re: [U-Boot] [PATCH] Add splash screen support via loading from flash

2013-06-03 Thread Stefano Babic
Hi Robert, On 30/05/2013 23:03, Robert Winkler wrote: > Signed-off-by: Robert Winkler > --- > board/boundary/nitrogen6x/nitrogen6x.c | 22 ++ > include/configs/nitrogen6x.h | 11 ++- > 2 files changed, 32 insertions(+), 1 deletion(-) > > diff --git a/board

Re: [U-Boot] [PATCH] Add splash screen support via loading from flash

2013-05-31 Thread Robert Winkler
On Fri, May 31, 2013 at 12:49 AM, Wolfgang Denk wrote: > > Dear Robert, > > In message > you > wrote: > > > > > > board/boundary/nitrogen6x/nitrogen6x.c | 22 ++ > > > > include/configs/nitrogen6x.h | 11 ++- > > > > 2 files changed, 32 insertions(+), 1 de

Re: [U-Boot] [PATCH] Add splash screen support via loading from flash

2013-05-31 Thread Wolfgang Denk
Dear Robert, In message you wrote: > > > > board/boundary/nitrogen6x/nitrogen6x.c | 22 ++ > > > include/configs/nitrogen6x.h | 11 ++- > > > 2 files changed, 32 insertions(+), 1 deletion(-) > > > > Could you please explain why you need custom code here? >

Re: [U-Boot] [PATCH] Add splash screen support via loading from flash

2013-05-30 Thread Robert Winkler
On Thu, May 30, 2013 at 4:32 PM, Wolfgang Denk wrote: > Dear Robert Winkler, > > In message < > 1369947781-25077-1-git-send-email-robert.wink...@boundarydevices.com> you > wrote: > > Signed-off-by: Robert Winkler > > --- > > board/boundary/nitrogen6x/nitrogen6x.c | 22 ++ > >

Re: [U-Boot] [PATCH] Add splash screen support via loading from flash

2013-05-30 Thread Wolfgang Denk
Dear Robert Winkler, In message <1369947781-25077-1-git-send-email-robert.wink...@boundarydevices.com> you wrote: > Signed-off-by: Robert Winkler > --- > board/boundary/nitrogen6x/nitrogen6x.c | 22 ++ > include/configs/nitrogen6x.h | 11 ++- > 2 files cha

[U-Boot] [PATCH] Add splash screen support via loading from flash

2013-05-30 Thread Robert Winkler
Signed-off-by: Robert Winkler --- board/boundary/nitrogen6x/nitrogen6x.c | 22 ++ include/configs/nitrogen6x.h | 11 ++- 2 files changed, 32 insertions(+), 1 deletion(-) diff --git a/board/boundary/nitrogen6x/nitrogen6x.c b/board/boundary/nitrogen6x/nitroge