Thanks for the review! I have some questions below that'll help me get
rev 2 correct.
Scott Wood wrote:
> On Fri, May 01, 2009 at 04:24:20PM -0400, Josh Karabin wrote:
>> @@ -119,8 +121,12 @@ arg_off_size(int argc, char *argv[], nand_info_t *nand,
>> ulong *off, size_t *size
>>
Josh Karabin wrote:
>> Why not support plussed for read as well?
>
> "read" isn't strictly necessary, since the existing code permits lengths
> that result in page-unaligned reads.
Would be nice to keep the syntax consistent and not error if the user
does provide a plus, though.
> Other operati
On Fri, May 01, 2009 at 04:24:20PM -0400, Josh Karabin wrote:
> @@ -119,8 +121,12 @@ arg_off_size(int argc, char *argv[], nand_info_t *nand,
> ulong *off, size_t *size
> }
> *off = part->offset;
> if (argc >= 2) {
> -
This change implements the suggestion from an earlier thread for
how to handle padding of non-page sized writes to NAND flashes.
See http://lists.denx.de/pipermail/u-boot/2009-February/047795.html
for the original discussion. Note that validity of tail page's
memory is the reponsibility of the ca
4 matches
Mail list logo