Re: [U-Boot] [PATCH] ARM: mach-omap2: omap3: Fix GPIO clocking in SPL

2018-12-14 Thread Liam O'Shaughnessey
V2 works for me on omap3_overo. Tested-by: Liam O'Shaughnessy On Fri, Dec 14, 2018 at 2:39 PM Adam Ford wrote: > > On Fri, Dec 14, 2018 at 4:21 PM Liam O'Shaughnessey > wrote: > > > > Not sure why, but this patch didn't work for me on omap3_overo and would > > like to NAK this patch. I need

Re: [U-Boot] [PATCH] ARM: mach-omap2: omap3: Fix GPIO clocking in SPL

2018-12-14 Thread Adam Ford
On Fri, Dec 14, 2018 at 4:21 PM Liam O'Shaughnessey wrote: > > Not sure why, but this patch didn't work for me on omap3_overo and would like > to NAK this patch. I needed to change to: > > #if defined(CONFIG_OMAP3_GPIO2) > blah! I forgot to add the CONFIG_ prefix. My bad. A V2 is now avaiabl

Re: [U-Boot] [PATCH] ARM: mach-omap2: omap3: Fix GPIO clocking in SPL

2018-12-14 Thread Liam O'Shaughnessey
Not sure why, but this patch didn't work for me on omap3_overo and would like to NAK this patch. I needed to change to: #if defined(CONFIG_OMAP3_GPIO2) On Fri, Dec 14, 2018 at 12:49 PM Adam Ford wrote: > OMAP3_GPIO_x is needed to enable each GPIO bank on the OMAP3 > boards. At one point, the #

[U-Boot] [PATCH] ARM: mach-omap2: omap3: Fix GPIO clocking in SPL

2018-12-14 Thread Adam Ford
OMAP3_GPIO_x is needed to enable each GPIO bank on the OMAP3 boards. At one point, the #ifdef's were replaced with if CONFIG_IS_ENABLED but this won't work for people who need OMAP3_GPIO_x in SPL since the SPL prefix for this option isn't used in Kconfig. This patch moves the check to #if defined