Re: [U-Boot] [PATCH][v4] powerpc: eSPI and eSPI controller support

2011-04-26 Thread Xie Shaohui-B21989
>On Tue, Apr 26, 2011 at 01:42, Shaohui Xie wrote: >> +struct spi_slave *spi_setup_slave(unsigned int bus, unsigned int cs, >> +               unsigned int max_hz, unsigned int mode) { >> +       fsl = malloc(sizeof(struct fsl_spi_slave)); > >personally, i like to use sizeof(*fsl). up to you. >

Re: [U-Boot] [PATCH][v4] powerpc: eSPI and eSPI controller support

2011-04-26 Thread Mike Frysinger
On Tue, Apr 26, 2011 at 01:42, Shaohui Xie wrote: > +struct spi_slave *spi_setup_slave(unsigned int bus, unsigned int cs, > +               unsigned int max_hz, unsigned int mode) > +{ > +       fsl = malloc(sizeof(struct fsl_spi_slave)); personally, i like to use sizeof(*fsl). up to you. > +  

Re: [U-Boot] [PATCH][v4] powerpc: eSPI and eSPI controller support

2011-04-26 Thread Xie Shaohui-B21989
>-Original Message- >From: Wolfgang Denk [mailto:w...@denx.de] >Sent: Tuesday, April 26, 2011 2:51 PM >To: Xie Shaohui-B21989 >Cc: u-boot@lists.denx.de; Gala Kumar-B11780 >Subject: Re: [U-Boot] [PATCH][v4] powerpc: eSPI and eSPI controller >support > >Dear

Re: [U-Boot] [PATCH][v4] powerpc: eSPI and eSPI controller support

2011-04-25 Thread Wolfgang Denk
Dear Shaohui Xie, In message <1303796554-29675-1-git-send-email-b21...@freescale.com> you wrote: > From: Mingkai Hu > > Signed-off-by: Mingkai Hu > Singed-off-by: Jerry Huang > Signed-off-by: Shaohui Xie > Cc: Mike Frysinger ... > + if (pm > 16) { > + pm = 16;

[U-Boot] [PATCH][v4] powerpc: eSPI and eSPI controller support

2011-04-25 Thread Shaohui Xie
From: Mingkai Hu Signed-off-by: Mingkai Hu Singed-off-by: Jerry Huang Signed-off-by: Shaohui Xie Cc: Mike Frysinger changes for v2: remove #ifdef wrapper and refactor spi_xfer by use SPI_XFER(BEGIN | END). remove 'volatile' use I/O accessors instead. changes for v3: move powerpc specifi