Re: [U-Boot] [PATCH][Net] Convert SMC91111 Ethernet driver toCONFIG_NET_MULTI API

2009-07-27 Thread Mike Frysinger
On Monday 27 July 2009 18:16:27 Robin Getz wrote: > On Mon 27 Jul 2009 17:43, Ben Warren pondered: > > All in-tree boards that use this controller have CONFIG_NET_MULTI > > added > > First - thanks. > > Second - It's a style thing, but... > > > --- > > board/bf533-ezkit/bf533-ezkit.c

Re: [U-Boot] [PATCH][Net] Convert SMC91111 Ethernet driver toCONFIG_NET_MULTI API

2009-07-27 Thread Robin Getz
On Mon 27 Jul 2009 18:17, Ben Warren pondered: > I actually like to have them in the board C code.  To the casual > observer, it is obvious that certain ethernet controllers are optional, > whereas if all they see is a string of initialization functions for > different chips they might say, "WTF

Re: [U-Boot] [PATCH][Net] Convert SMC91111 Ethernet driver toCONFIG_NET_MULTI API

2009-07-27 Thread Ben Warren
Hi Robin, Robin Getz wrote: > On Mon 27 Jul 2009 17:43, Ben Warren pondered: > >> All in-tree boards that use this controller have CONFIG_NET_MULTI >> added >> > > First - thanks. > > Second - It's a style thing, but... > > >> --- >> board/bf533-ezkit/bf533-ezkit.c | 12

Re: [U-Boot] [PATCH][Net] Convert SMC91111 Ethernet driver toCONFIG_NET_MULTI API

2009-07-27 Thread Robin Getz
On Mon 27 Jul 2009 17:43, Ben Warren pondered: > All in-tree boards that use this controller have CONFIG_NET_MULTI > added First - thanks. Second - It's a style thing, but... > --- > board/bf533-ezkit/bf533-ezkit.c | 12 + > include/netdev.h |1 +