Re: [U-Boot] [EXT] Re: [PATCH v2 4/4] armv8: ls2088aqds : Add ds3232 node

2019-07-25 Thread Chuanhua Han
> -Original Message- > From: Wolfgang Denk > Sent: 2019年7月26日 14:26 > To: Chuanhua Han > Cc: albert.u.b...@aribaud.net; Prabhakar Kushwaha > ; Priyanka Jain ; > Rajesh Bhagat ; u-boot@lists.denx.de; > lu...@denx.de; tr...@konsulko.com > Subject: Re: [EXT] Re: [PATCH v2 4/4] armv8: ls208

Re: [U-Boot] [EXT] Re: [PATCH v2 4/4] armv8: ls2088aqds : Add ds3232 node

2019-07-25 Thread Wolfgang Denk
Dear Chuanhua Han, In message you wrote: > > > Is this bisectable? You first enable the feature in the code, and only > > later add > > the needed property to the DT? Should it not be reversed? > This should not matter because they are in the same patch set You completely miss the point wh

Re: [U-Boot] [EXT] Re: [PATCH v2 4/4] armv8: ls2088aqds : Add ds3232 node

2019-07-25 Thread Chuanhua Han
> -Original Message- > From: Wolfgang Denk > Sent: 2019年7月25日 15:41 > To: Chuanhua Han > Cc: albert.u.b...@aribaud.net; Prabhakar Kushwaha > ; Priyanka Jain ; > Rajesh Bhagat ; u-boot@lists.denx.de; > lu...@denx.de; tr...@konsulko.com > Subject: [EXT] Re: [PATCH v2 4/4] armv8: ls2088aqd