On Mon, 16 Dec 2019 18:15:01 +0530
Amit Tomer wrote:
Hi,
> Thanks for having the look.
thanks for the reply and the comments.
[ ... ]
> > > +#define TDMA_RING_REG_BASE(QUEUE_NUMBER) (GENET_TDMA_REG_OFF \
> > > ++ (DMA_RING_SIZE * (QUEUE_NUMBER)))
> >
> > So it seems
Hi,
Thanks for having the look.
>
> I am afraid that needs to be more elaborate. You could mention Broadcom, also
> that it's only for v5 of it. And that it's based on reverse engineering the
> Linux driver.
> Text in the cover letter will not make it into the repo, so you should
> mention thi
On Fri, 13 Dec 2019 15:53:24 -0800
Florian Fainelli wrote:
Hi Florian,
many thanks for your reply!
> On 12/13/2019 8:50 AM, Andre Przywara wrote:
> >> +/* total number of Buffer Descriptors, same for Rx/Tx */
> >> +#define TOTAL_DESC 256
> >> +
> >> +#define DEFAULT_Q
On 12/13/2019 8:50 AM, Andre Przywara wrote:
>> +/* total number of Buffer Descriptors, same for Rx/Tx */
>> +#define TOTAL_DESC 256
>> +
>> +#define DEFAULT_Q0x10
>
> I think that deserves a comment.
> Maybe Florian can comment on what this odd "queue
On Fri, 13 Dec 2019 21:12:22 +0530
Amit Singh Tomar wrote:
Hi Amit,
thanks for your work on this.
As I have seen versions of this code before, here just some quick things
(mostly stylistic) that I spotted earlier.
> This patch adds driver for GENET Ethernet controller.
>
> It has been tested(
This patch adds driver for GENET Ethernet controller.
It has been tested(ping and tftp works for small files) on
Raspberry Pi 4.
Signed-off-by: Amit Singh Tomar
---
configs/rpi_4_defconfig | 2 +
drivers/net/Kconfig | 7 +
drivers/net/Makefile| 1 +
drivers/net/bcmgenet.c | 770 +
6 matches
Mail list logo
