Re: [RFC PATCH] test/py: Check hashes produced by mkimage against known values

2021-10-05 Thread Tom Rini
On Wed, Sep 15, 2021 at 02:33:01PM -0500, Alexandru Gagniuc wrote: > Target code and mkimage share the same hashing infrastructure. If one > is wrong, it's very likely that both are wrong in the same way. Thus > testing won't catch hash regressions. This already happened in > commit 92055e138f28 (

Re: [RFC PATCH] test/py: Check hashes produced by mkimage against known values

2021-09-29 Thread Simon Glass
On Wed, 15 Sept 2021 at 13:33, Alexandru Gagniuc wrote: > > Target code and mkimage share the same hashing infrastructure. If one > is wrong, it's very likely that both are wrong in the same way. Thus > testing won't catch hash regressions. This already happened in > commit 92055e138f28 ("image: D

[RFC PATCH] test/py: Check hashes produced by mkimage against known values

2021-09-15 Thread Alexandru Gagniuc
Target code and mkimage share the same hashing infrastructure. If one is wrong, it's very likely that both are wrong in the same way. Thus testing won't catch hash regressions. This already happened in commit 92055e138f28 ("image: Drop if/elseif hash selection in calculate_hash()"). None of the tes