Re: [RFC PATCH] efi_loader: clean up uefi secure boot image verification logic

2022-01-24 Thread Ilias Apalodimas
Hi Akashi-san, On Tue, Jan 25, 2022 at 11:31:07AM +0900, AKASHI Takahiro wrote: > Hi Ilias, > > On Mon, Jan 24, 2022 at 05:36:20PM +0200, Ilias Apalodimas wrote: > > From: Ilias Apalodimas > > > > We currently distinguish between signed and non signed PE/COFF > > executables while trying to au

Re: [RFC PATCH] efi_loader: clean up uefi secure boot image verification logic

2022-01-24 Thread AKASHI Takahiro
Hi Ilias, On Mon, Jan 24, 2022 at 05:36:20PM +0200, Ilias Apalodimas wrote: > From: Ilias Apalodimas > > We currently distinguish between signed and non signed PE/COFF > executables while trying to authenticate signatures and/or sha256 > hashes in db and dbx. That code duplication can be avoide

Re: [RFC PATCH] efi_loader: clean up uefi secure boot image verification logic

2022-01-24 Thread Heinrich Schuchardt
On 1/24/22 16:36, Ilias Apalodimas wrote: From: Ilias Apalodimas We currently distinguish between signed and non signed PE/COFF executables while trying to authenticate signatures and/or sha256 hashes in db and dbx. That code duplication can be avoided. On sha256 hashes we don't really care if

[RFC PATCH] efi_loader: clean up uefi secure boot image verification logic

2022-01-24 Thread Ilias Apalodimas
From: Ilias Apalodimas We currently distinguish between signed and non signed PE/COFF executables while trying to authenticate signatures and/or sha256 hashes in db and dbx. That code duplication can be avoided. On sha256 hashes we don't really care if the image is signed or not. The logic can