Re: [RESEND PATCH v3 7/9] net/tcp: simplify tcp header filling code

2024-08-28 Thread Peter Robinson
This needs an actual description, please add details what and why for this 70 line patch. > Signed-off-by: Mikhail Kshevetskiy > --- > net/tcp.c | 70 +-- > 1 file changed, 37 insertions(+), 33 deletions(-) > > diff --git a/net/tcp.c b/net/tcp.

Re: [RESEND PATCH v3 7/9] net/tcp: simplify tcp header filling code

2024-08-26 Thread Simon Glass
Hi Mikhail, On Sat, 24 Aug 2024 at 06:30, Mikhail Kshevetskiy wrote: > > actually I know nothing about sandbox emulator This is the foundation of U-Boot's testing [1]. See for example test/cmd/wget.c > > > On 23.08.2024 23:47, Simon Glass wrote: > > Hi Mikhail, > > > > On Fri, 23 Aug 2024 at 09

Re: [RESEND PATCH v3 7/9] net/tcp: simplify tcp header filling code

2024-08-24 Thread Mikhail Kshevetskiy
actually I know nothing about sandbox emulator On 23.08.2024 23:47, Simon Glass wrote: > Hi Mikhail, > > On Fri, 23 Aug 2024 at 09:12, Mikhail Kshevetskiy > wrote: >> By the way, I'd like to know your opinion: >> * should I add a sample implementation of http/1.1 compatible >> web-server to thi

Re: [RESEND PATCH v3 7/9] net/tcp: simplify tcp header filling code

2024-08-23 Thread Simon Glass
Hi Mikhail, On Fri, 23 Aug 2024 at 09:12, Mikhail Kshevetskiy wrote: > > By the way, I'd like to know your opinion: > * should I add a sample implementation of http/1.1 compatible > web-server to this patch series? > > This can be used as a base for other implementations like firmware > upgrade

Re: [RESEND PATCH v3 7/9] net/tcp: simplify tcp header filling code

2024-08-23 Thread Mikhail Kshevetskiy
By the way, I'd like to know your opinion:  * should I add a sample implementation of http/1.1 compatible web-server to this patch series? This can be used as a base for other implementations like firmware upgrade web-server used by some vendors. Mikhail Kshevetskiy On 17.08.2024 18:58, Simon G

Re: [RESEND PATCH v3 7/9] net/tcp: simplify tcp header filling code

2024-08-17 Thread Simon Glass
Hi Mikhail, On Wed, 14 Aug 2024 at 04:32, Mikhail Kshevetskiy wrote: > > Signed-off-by: Mikhail Kshevetskiy > --- > net/tcp.c | 70 +-- > 1 file changed, 37 insertions(+), 33 deletions(-) > Reviewed-by: Simon Glass nits below > diff --git

[RESEND PATCH v3 7/9] net/tcp: simplify tcp header filling code

2024-08-14 Thread Mikhail Kshevetskiy
Signed-off-by: Mikhail Kshevetskiy --- net/tcp.c | 70 +-- 1 file changed, 37 insertions(+), 33 deletions(-) diff --git a/net/tcp.c b/net/tcp.c index 2c34556c26d..7014d5b4f43 100644 --- a/net/tcp.c +++ b/net/tcp.c @@ -527,10 +527,37 @@ void net