Re: [RESEND PATCH v3 1/2] cli: Correct several bugs in cli_getch()

2023-03-28 Thread Tom Rini
On Tue, 28 Mar 2023 08:34:13 +1300, Simon Glass wrote: > This function does not behave as expected when unknown escape sequences > are sent to it: > > - it fails to store (and thus echo) the last character of the invalid > sequence > - it fails to set esc_len to 0 when it finishes emitting the

[RESEND PATCH v3 1/2] cli: Correct several bugs in cli_getch()

2023-03-27 Thread Simon Glass
This function does not behave as expected when unknown escape sequences are sent to it: - it fails to store (and thus echo) the last character of the invalid sequence - it fails to set esc_len to 0 when it finishes emitting the invalid sequence, meaning that the following character will appear

[RESEND PATCH v3 1/2] cli: Correct several bugs in cli_getch()

2023-03-27 Thread Simon Glass
This function does not behave as expected when unknown escape sequences are sent to it: - it fails to store (and thus echo) the last character of the invalid sequence - it fails to set esc_len to 0 when it finishes emitting the invalid sequence, meaning that the following character will appear

Re: [RESEND PATCH v3 1/2] cli: Correct several bugs in cli_getch()

2023-03-27 Thread Simon Glass
+Tom Rini Hi, On Tue, 28 Mar 2023 at 08:04, Simon Glass wrote: > > This function does not behave as expected when unknown escape sequences > are sent to it: > > - it fails to store (and thus echo) the last character of the invalid > sequence > - it fails to set esc_len to 0 when it finishes em