Re: [PATCHv3] cmd/gpt: Address error cases during gpt rename more correctly

2020-01-30 Thread Tom Rini
On Tue, Jan 21, 2020 at 11:53:38AM -0500, Tom Rini wrote: > New analysis by the tool has shown that we have some cases where we > weren't handling the error exit condition correctly. When we ran into > the ENOMEM case we wouldn't exit the function and thus incorrect things > could happen. Rework

Re: [PATCHv3] cmd/gpt: Address error cases during gpt rename more correctly

2020-01-22 Thread Jordy
Just caught up with all the patches and the final one indeed looks good to me too! Kind Regards, Jordy > On January 22, 2020 2:20 AM Simon Goldschmidt > wrote: > > > On Tue, Jan 21, 2020 at 5:53 PM Tom Rini wrote: > > > > New analysis by the tool has shown that we have some cases where we

Re: [PATCHv3] cmd/gpt: Address error cases during gpt rename more correctly

2020-01-21 Thread Simon Goldschmidt
On Tue, Jan 21, 2020 at 5:53 PM Tom Rini wrote: > > New analysis by the tool has shown that we have some cases where we > weren't handling the error exit condition correctly. When we ran into > the ENOMEM case we wouldn't exit the function and thus incorrect things > could happen. Rework the unw

[PATCHv3] cmd/gpt: Address error cases during gpt rename more correctly

2020-01-21 Thread Tom Rini
New analysis by the tool has shown that we have some cases where we weren't handling the error exit condition correctly. When we ran into the ENOMEM case we wouldn't exit the function and thus incorrect things could happen. Rework the unwinding such that we don't need a helper function now and fr