Re: [PATCH v8 4/8] net: dsa: allow rcv() and xmit() to be optional

2022-11-30 Thread Tim Harvey
On Wed, Nov 30, 2022 at 9:25 AM Vladimir Oltean wrote: > > On Tue, Nov 29, 2022 at 04:58:33PM -0800, Tim Harvey wrote: > > Yes, it makes sense. How about the following patch instead: > > > > diff --git a/net/dsa-uclass.c b/net/dsa-uclass.c > > index 211a991cdd0d..1ae9adc66eda 100644 > > --- a/net/

Re: [PATCH v8 4/8] net: dsa: allow rcv() and xmit() to be optional

2022-11-30 Thread Vladimir Oltean
On Tue, Nov 29, 2022 at 04:58:33PM -0800, Tim Harvey wrote: > Yes, it makes sense. How about the following patch instead: > > diff --git a/net/dsa-uclass.c b/net/dsa-uclass.c > index 211a991cdd0d..1ae9adc66eda 100644 > --- a/net/dsa-uclass.c > +++ b/net/dsa-uclass.c > @@ -142,6 +142,9 @@ static in

Re: [PATCH v8 4/8] net: dsa: allow rcv() and xmit() to be optional

2022-11-29 Thread Tim Harvey
On Tue, Nov 29, 2022 at 4:11 PM Vladimir Oltean wrote: > > On Tue, Nov 29, 2022 at 02:53:15PM -0800, Tim Harvey wrote: > > On Mon, Nov 28, 2022 at 7:58 AM Tom Rini wrote: > > > > > > On Thu, Oct 27, 2022 at 05:49:33PM -0700, Tim Harvey wrote: > > > > > > > Allow rcv() and xmit() dsa driver ops to

Re: [PATCH v8 4/8] net: dsa: allow rcv() and xmit() to be optional

2022-11-29 Thread Vladimir Oltean
On Tue, Nov 29, 2022 at 02:53:15PM -0800, Tim Harvey wrote: > On Mon, Nov 28, 2022 at 7:58 AM Tom Rini wrote: > > > > On Thu, Oct 27, 2022 at 05:49:33PM -0700, Tim Harvey wrote: > > > > > Allow rcv() and xmit() dsa driver ops to be optional in case a driver > > > does not care to mangle a packet a

Re: [PATCH v8 4/8] net: dsa: allow rcv() and xmit() to be optional

2022-11-29 Thread Tom Rini
On Tue, Nov 29, 2022 at 02:53:15PM -0800, Tim Harvey wrote: > On Mon, Nov 28, 2022 at 7:58 AM Tom Rini wrote: > > > > On Thu, Oct 27, 2022 at 05:49:33PM -0700, Tim Harvey wrote: > > > > > Allow rcv() and xmit() dsa driver ops to be optional in case a driver > > > does not care to mangle a packet a

Re: [PATCH v8 4/8] net: dsa: allow rcv() and xmit() to be optional

2022-11-29 Thread Tim Harvey
On Mon, Nov 28, 2022 at 7:58 AM Tom Rini wrote: > > On Thu, Oct 27, 2022 at 05:49:33PM -0700, Tim Harvey wrote: > > > Allow rcv() and xmit() dsa driver ops to be optional in case a driver > > does not care to mangle a packet as in U-Boot only one network port is > > enabled at a time and thus no p

Re: [PATCH v8 4/8] net: dsa: allow rcv() and xmit() to be optional

2022-11-28 Thread Tom Rini
On Thu, Oct 27, 2022 at 05:49:33PM -0700, Tim Harvey wrote: > Allow rcv() and xmit() dsa driver ops to be optional in case a driver > does not care to mangle a packet as in U-Boot only one network port is > enabled at a time and thus no packet mangling is necessary. > > Suggested-by: Vladimir Olt

[PATCH v8 4/8] net: dsa: allow rcv() and xmit() to be optional

2022-10-27 Thread Tim Harvey
Allow rcv() and xmit() dsa driver ops to be optional in case a driver does not care to mangle a packet as in U-Boot only one network port is enabled at a time and thus no packet mangling is necessary. Suggested-by: Vladimir Oltean Signed-off-by: Tim Harvey Reviewed-by: Vladimir Oltean Reviewed-