Re: [PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-19 Thread Simon Glass
Hi Wolfgang, On Tue, 19 Oct 2021 at 10:09, Wolfgang Denk wrote: > > Dear Simon, > > In message > you > wrote: > > > > I thought you were trying to use + at the end of a variable. > > > > I used: > > > > fred\+=aaa > > > > and got > > > > cc1: warning: unknown escape sequence: '\='' > > > > You

Re: [PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-19 Thread Wolfgang Denk
Dear Simon, In message you wrote: > > I thought you were trying to use + at the end of a variable. > > I used: > > fred\+=aaa > > and got > > cc1: warning: unknown escape sequence: '\='' > > You can try it yourself by editing sandbox.env in the > u-boot-dm/env-working tree. Hmmm... -> cat foo.

Re: [PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-19 Thread Simon Glass
Hi Wolfgang, On Tue, 19 Oct 2021 at 04:46, Wolfgang Denk wrote: > > Dear Simon, > > In message > you > wrote: > > > > Can we just ban + ? > > Why? Just because your awk script is a lousy parser? > > > In the above, foo\+ gives an unknown escape sequence from the C > > preprocessor, then the w

Re: [PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-19 Thread Wolfgang Denk
Dear Simon, In message you wrote: > > Can we just ban + ? Why? Just because your awk script is a lousy parser? > In the above, foo\+ gives an unknown escape sequence from the C > preprocessor, then the whole line is ignored by the script Really? -> cat foo.c #define A ampersand #define B be

Re: [PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-19 Thread Wolfgang Denk
Dear Simon, In message you wrote: > > > Hm... I can't find it right now but did I not also read about other > > restrictions to variable names, like they must noch begin with '_' > > when using this new tool? > > Yes but I took that out (I think in v6). I'll update the commit message. Why exact

Re: [PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-19 Thread Wolfgang Denk
Dear Tom, In message <20211018142404.GR7964@bill-the-cat> you wrote: > > > > Perhaps we should just make "+" an illegal character in the variable > > > name, for consistency? > > > > And break backward compatibility? I'd rather see a better > > definition of the syntax of the environment files,

Re: [PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-18 Thread Simon Glass
Hi Wolfgang, On Mon, 18 Oct 2021 at 05:59, Wolfgang Denk wrote: > > Dear Simon, > > In message > you > wrote: > > > > > I really think your fixed filename proposal does not work well in > > > reality. The file name should be Kconfig configurable. See [1] > > > for details. > > > > > > [1] htt

Re: [PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-18 Thread Simon Glass
Hi Wolfgang, On Mon, 18 Oct 2021 at 08:10, Wolfgang Denk wrote: > > Dear Tom, > > In message <20211018133728.GQ7964@bill-the-cat> you wrote: > > > > > And please see also my comments about changing the autostart > > > functionality for the user. > > > > Perhaps we should just make "+" an illegal

Re: [PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-18 Thread Tom Rini
On Mon, Oct 18, 2021 at 04:10:34PM +0200, Wolfgang Denk wrote: > Dear Tom, > > In message <20211018133728.GQ7964@bill-the-cat> you wrote: > > > > > And please see also my comments about changing the autostart > > > functionality for the user. > > > > Perhaps we should just make "+" an illegal cha

Re: [PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-18 Thread Wolfgang Denk
Dear Tom, In message <20211018133728.GQ7964@bill-the-cat> you wrote: > > > And please see also my comments about changing the autostart > > functionality for the user. > > Perhaps we should just make "+" an illegal character in the variable > name, for consistency? And break backward compatibili

Re: [PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-18 Thread Tom Rini
On Mon, Oct 18, 2021 at 01:58:57PM +0200, Wolfgang Denk wrote: > Dear Simon, > > In message > you > wrote: > > > > > I really think your fixed filename proposal does not work well in > > > reality. The file name should be Kconfig configurable. See [1] > > > for details. > > > > > > [1] https:/

Re: [PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-18 Thread Wolfgang Denk
Dear Simon, In message you wrote: > > > I really think your fixed filename proposal does not work well in > > reality. The file name should be Kconfig configurable. See [1] > > for details. > > > > [1] https://lists.denx.de/pipermail/u-boot/2021-October/462668.html > > Yes I saw that but I forg

Re: [PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-15 Thread Simon Glass
Hi Wolfgang, On Fri, 15 Oct 2021 at 08:32, Wolfgang Denk wrote: > > Dear Simon Glass, > > In message > <20211014122254.v6.4.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> you > wrote: > > At present U-Boot environment variables, and thus scripts, are defined > > by CONFIG_EXTRA_ENV_SETTING

Re: [PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-15 Thread Wolfgang Denk
Dear Simon Glass, In message <20211014122254.v6.4.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> you wrote: > At present U-Boot environment variables, and thus scripts, are defined > by CONFIG_EXTRA_ENV_SETTINGS. It is painful to add large amounts of text > to this file and dealing with quo

[PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-14 Thread Simon Glass
At present U-Boot environment variables, and thus scripts, are defined by CONFIG_EXTRA_ENV_SETTINGS. It is painful to add large amounts of text to this file and dealing with quoting and newlines is harder than it should be. It would be better if we could just type the script into a text file and ha