Re: [PATCH v6 08/25] spl: Refactor spl_load_info->read to use units of bytes

2023-11-08 Thread Xavier Drudis Ferran
El Wed, Nov 08, 2023 at 10:59:13AM -0500, Sean Anderson deia: > > OK, what about > > @offset: Offset to read from in bytes. This must be a multiple of > @load->bl_len. > > --Sean Great. Thank you.

Re: [PATCH v6 08/25] spl: Refactor spl_load_info->read to use units of bytes

2023-11-08 Thread Sean Anderson
On 11/7/23 03:49, Xavier Drudis Ferran wrote: El Mon, Nov 06, 2023 at 08:54:03AM -0500, Sean Anderson deia: On 11/6/23 07:35, Xavier Drudis Ferran wrote: Thanks for your work. I'm still reading... but... El Sun, Nov 05, 2023 at 09:25:46PM -0500, Sean Anderson deia: diff --git a/include/spl.h

Re: [PATCH v6 08/25] spl: Refactor spl_load_info->read to use units of bytes

2023-11-07 Thread Xavier Drudis Ferran
El Mon, Nov 06, 2023 at 08:54:03AM -0500, Sean Anderson deia: > On 11/6/23 07:35, Xavier Drudis Ferran wrote: > > Thanks for your work. I'm still reading... but... > > > > > > El Sun, Nov 05, 2023 at 09:25:46PM -0500, Sean Anderson deia: > > > diff --git a/include/spl.h b/include/spl.h > > > inde

Re: [PATCH v6 08/25] spl: Refactor spl_load_info->read to use units of bytes

2023-11-06 Thread Sean Anderson
On 11/6/23 07:35, Xavier Drudis Ferran wrote: Thanks for your work. I'm still reading... but... El Sun, Nov 05, 2023 at 09:25:46PM -0500, Sean Anderson deia: diff --git a/include/spl.h b/include/spl.h index 951e136b9ea..ecfc50e0095 100644 --- a/include/spl.h +++ b/include/spl.h @@ -297,10 +297

Re: [PATCH v6 08/25] spl: Refactor spl_load_info->read to use units of bytes

2023-11-06 Thread Xavier Drudis Ferran
Thanks for your work. I'm still reading... but... El Sun, Nov 05, 2023 at 09:25:46PM -0500, Sean Anderson deia: > diff --git a/include/spl.h b/include/spl.h > index 951e136b9ea..ecfc50e0095 100644 > --- a/include/spl.h > +++ b/include/spl.h > @@ -297,10 +297,10 @@ struct spl_load_info { >

[PATCH v6 08/25] spl: Refactor spl_load_info->read to use units of bytes

2023-11-05 Thread Sean Anderson
Simplify things a bit for callers of spl_load_info->read by refactoring it to use units of bytes instead of bl_len. This generally simplifies the logic, as MMC is the only loader which actually works in sectors. It will also allow further refactoring to remove the special-case handling of filename.