Re: [PATCH v6 05/12] power-domain: Add refcounting

2025-04-16 Thread Miquel Raynal
On 16/04/2025 at 16:20:06 +03, Wadim Egorov wrote: > Am 16.04.25 um 12:50 schrieb Neha Malcom Francis: >> Hi Miquel >> On 16/04/25 14:36, Miquel Raynal wrote: >>> Hello, >>> >> -int power_domain_on(struct power_domain *power_domain) >> +int power_domain_on_lowlevel(struct power_domain *po

Re: [PATCH v6 05/12] power-domain: Add refcounting

2025-04-16 Thread Wadim Egorov
Am 16.04.25 um 12:50 schrieb Neha Malcom Francis: Hi Miquel On 16/04/25 14:36, Miquel Raynal wrote: Hello, -int power_domain_on(struct power_domain *power_domain) +int power_domain_on_lowlevel(struct power_domain *power_domain) { + struct power_domain_priv *priv = dev_get_uclass_priv(

Re: [PATCH v6 05/12] power-domain: Add refcounting

2025-04-16 Thread Miquel Raynal
Hello, >>> -int power_domain_on(struct power_domain *power_domain) >>> +int power_domain_on_lowlevel(struct power_domain *power_domain) >>> { >>> + struct power_domain_priv *priv = dev_get_uclass_priv(power_domain->dev); >>> struct power_domain_ops *ops = power_domain_dev_ops(power_domain->

Re: [PATCH v6 05/12] power-domain: Add refcounting

2025-04-16 Thread Neha Malcom Francis
Hi Miquel On 16/04/25 14:36, Miquel Raynal wrote: > Hello, > -int power_domain_on(struct power_domain *power_domain) +int power_domain_on_lowlevel(struct power_domain *power_domain) { + struct power_domain_priv *priv = dev_get_uclass_priv(power_domain->dev); struct p

Re: [PATCH v6 05/12] power-domain: Add refcounting

2025-04-16 Thread Neha Malcom Francis
Hi Samuel On 16/04/25 06:44, Samuel Holland wrote: > Hi Miquel, > > On 2025-04-03 2:39 AM, Miquel Raynal wrote: >> It is very surprising that such an uclass, specifically designed to >> handle resources that may be shared by different devices, is not keeping >> the count of the number of times a

Re: [PATCH v6 05/12] power-domain: Add refcounting

2025-04-16 Thread Neha Malcom Francis
On 15/04/25 18:13, Miquel Raynal wrote: > On 15/04/2025 at 15:29:09 +0530, Neha Malcom Francis wrote: > >> Hi Miquel >> >> On 15/04/25 15:20, Miquel Raynal wrote: > Francesco, are you also testing on K3 platforms? > Yes he would be, since the firmware print is K3 firmware.

Re: [PATCH v6 05/12] power-domain: Add refcounting

2025-04-15 Thread Samuel Holland
Hi Miquel, On 2025-04-03 2:39 AM, Miquel Raynal wrote: > It is very surprising that such an uclass, specifically designed to > handle resources that may be shared by different devices, is not keeping > the count of the number of times a power domain has been > enabled/disabled to avoid shutting it

Re: [PATCH v6 05/12] power-domain: Add refcounting

2025-04-15 Thread Francis, Neha
On 4/3/2025 1:09 PM, Miquel Raynal wrote: > It is very surprising that such an uclass, specifically designed to > handle resources that may be shared by different devices, is not keeping > the count of the number of times a power domain has been > enabled/disabled to avoid shutting it down unexpect

Re: [PATCH v6 05/12] power-domain: Add refcounting

2025-04-15 Thread Miquel Raynal
On 15/04/2025 at 15:29:09 +0530, Neha Malcom Francis wrote: > Hi Miquel > > On 15/04/25 15:20, Miquel Raynal wrote: Francesco, are you also testing on K3 platforms? >>> >>> Yes he would be, since the firmware print is K3 firmware. >>> Can one of you boot with the patch below applie

Re: [PATCH v6 05/12] power-domain: Add refcounting

2025-04-15 Thread Miquel Raynal
>> Francesco, are you also testing on K3 platforms? >> > > Yes he would be, since the firmware print is K3 firmware. > >> Can one of you boot with the patch below applied? It should partially >> revert the commit to the ancient behaviour, while adding more debug >> traces (please enable the debug

Re: [PATCH v6 05/12] power-domain: Add refcounting

2025-04-15 Thread Miquel Raynal
Hello, Thanks for the report. >> >>> Neha bisected it down to 197376fbf300e92afa0a1583815d9c9eb52d613a commit >> >>> which is this patch. >> >> >> >> And assuming it's the same failure I got reported this morning by one of >> >> my coworkers, we just get: >> >> U-Boot SPL 2025.04-01050-ga40fc5afa

Re: [PATCH v6 05/12] power-domain: Add refcounting

2025-04-15 Thread Francesco Dolcini
On Tue, Apr 15, 2025 at 03:29:09PM +0530, Neha Malcom Francis wrote: > On 15/04/25 15:20, Miquel Raynal wrote: > >>> Francesco, are you also testing on K3 platforms? > >>> > >> > >> Yes he would be, since the firmware print is K3 firmware. > >> > >>> Can one of you boot with the patch below applied

Re: [PATCH v6 05/12] power-domain: Add refcounting

2025-04-15 Thread Neha Malcom Francis
Hi Miquel On 15/04/25 15:20, Miquel Raynal wrote: >>> Francesco, are you also testing on K3 platforms? >>> >> >> Yes he would be, since the firmware print is K3 firmware. >> >>> Can one of you boot with the patch below applied? It should partially >>> revert the commit to the ancient behaviour, wh

Re: [PATCH v6 05/12] power-domain: Add refcounting

2025-04-15 Thread Neha Malcom Francis
Hi Miquel On 15/04/25 13:45, Miquel Raynal wrote: > Hello, > > Thanks for the report. > >> Neha bisected it down to 197376fbf300e92afa0a1583815d9c9eb52d613a commit >> which is this patch. > > And assuming it's the same failure I got reported this morning by one of > my cowork

Re: [PATCH v6 05/12] power-domain: Add refcounting

2025-04-14 Thread Francesco Dolcini
Hello Tom, Neha On Tue, Apr 15, 2025 at 10:50:42AM +0530, Neha Malcom Francis wrote: > > > On 15/04/25 02:30, Francesco Dolcini wrote: > > On Mon, Apr 14, 2025 at 02:06:35PM -0600, Tom Rini wrote: > >> On Mon, Apr 14, 2025 at 01:07:27PM -0500, Nishanth Menon wrote: > >>> On 23:06-20250414, Franc

Re: [PATCH v6 05/12] power-domain: Add refcounting

2025-04-14 Thread Neha Malcom Francis
On 15/04/25 02:30, Francesco Dolcini wrote: > On Mon, Apr 14, 2025 at 02:06:35PM -0600, Tom Rini wrote: >> On Mon, Apr 14, 2025 at 01:07:27PM -0500, Nishanth Menon wrote: >>> On 23:06-20250414, Francis, Neha wrote: On 4/3/2025 1:09 PM, Miquel Raynal wrote: > It is very surprising that s

Re: [PATCH v6 05/12] power-domain: Add refcounting

2025-04-14 Thread Francesco Dolcini
On Mon, Apr 14, 2025 at 02:06:35PM -0600, Tom Rini wrote: > On Mon, Apr 14, 2025 at 01:07:27PM -0500, Nishanth Menon wrote: > > On 23:06-20250414, Francis, Neha wrote: > > > On 4/3/2025 1:09 PM, Miquel Raynal wrote: > > > > It is very surprising that such an uclass, specifically designed to > > > >

Re: [PATCH v6 05/12] power-domain: Add refcounting

2025-04-14 Thread Tom Rini
On Mon, Apr 14, 2025 at 01:07:27PM -0500, Nishanth Menon wrote: > On 23:06-20250414, Francis, Neha wrote: > > On 4/3/2025 1:09 PM, Miquel Raynal wrote: > > > It is very surprising that such an uclass, specifically designed to > > > handle resources that may be shared by different devices, is not ke

Re: [PATCH v6 05/12] power-domain: Add refcounting

2025-04-14 Thread Nishanth Menon
On 23:06-20250414, Francis, Neha wrote: > On 4/3/2025 1:09 PM, Miquel Raynal wrote: > > It is very surprising that such an uclass, specifically designed to > > handle resources that may be shared by different devices, is not keeping > > the count of the number of times a power domain has been > > e

[PATCH v6 05/12] power-domain: Add refcounting

2025-04-03 Thread Miquel Raynal
It is very surprising that such an uclass, specifically designed to handle resources that may be shared by different devices, is not keeping the count of the number of times a power domain has been enabled/disabled to avoid shutting it down unexpectedly or disabling it several times. Doing this ca