Re: [PATCH v5 3/9] board_f: Correct stack reservation

2024-12-03 Thread Simon Glass
Hi Tom, On Tue, 3 Dec 2024 at 07:00, Tom Rini wrote: > > On Tue, Dec 03, 2024 at 06:53:55AM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Mon, 2 Dec 2024 at 14:59, Tom Rini wrote: > > > > > > On Sun, Dec 01, 2024 at 08:28:05AM -0700, Simon Glass wrote: > > > > > > > The reserve_stack_aligned(

Re: [PATCH v5 3/9] board_f: Correct stack reservation

2024-12-03 Thread Tom Rini
On Tue, Dec 03, 2024 at 06:53:55AM -0700, Simon Glass wrote: > Hi Tom, > > On Mon, 2 Dec 2024 at 14:59, Tom Rini wrote: > > > > On Sun, Dec 01, 2024 at 08:28:05AM -0700, Simon Glass wrote: > > > > > The reserve_stack_aligned() function already ensures that the resulting > > > address is aligned t

Re: [PATCH v5 3/9] board_f: Correct stack reservation

2024-12-03 Thread Simon Glass
Hi Tom, On Mon, 2 Dec 2024 at 14:59, Tom Rini wrote: > > On Sun, Dec 01, 2024 at 08:28:05AM -0700, Simon Glass wrote: > > > The reserve_stack_aligned() function already ensures that the resulting > > address is aligned to a 16-byte boundary. The comment seems to suggest > > that 16 is passed rese

Re: [PATCH v5 3/9] board_f: Correct stack reservation

2024-12-02 Thread Tom Rini
On Sun, Dec 01, 2024 at 08:28:05AM -0700, Simon Glass wrote: > The reserve_stack_aligned() function already ensures that the resulting > address is aligned to a 16-byte boundary. The comment seems to suggest > that 16 is passed reserve_stack_aligned() to make it aligned. > > Change the value to 0

[PATCH v5 3/9] board_f: Correct stack reservation

2024-12-01 Thread Simon Glass
The reserve_stack_aligned() function already ensures that the resulting address is aligned to a 16-byte boundary. The comment seems to suggest that 16 is passed reserve_stack_aligned() to make it aligned. Change the value to 0, since the stack can start at the current address, if it is suitably al