Re: [PATCH v5 2/2] board: mediatek: add mt8195 demo board

Hi Fabien and Macpaul Thanks for your patch set. On Fri, 2023-08-04 at 19:04 +0800, Macpaul Lin wrote: > From: Fabien Parent > > Add mt8195-demo board support. > This demo purpose board uses MediaTek's MT8195 SoC. > > Signed-off-by: Fabien Parent > Signed-off-by: Amjad Ouled-Ameur > Signed-o

Re: [PATCH v5 2/2] board: mediatek: add mt8195 demo board

Hi, > + printf("Disabling WDT\n"); > + writel(0, 0x10007000); Please don't use magic numbers. Also, I guess this should be a real watchdog driver and u-boot will take care of disabling it if the user wants to. > + > + printf("Enabling SCP SRAM\n"); > + for (unsigned int val = 0xF

Re: [PATCH v5 2/2] board: mediatek: add mt8195 demo board

On Fri, Aug 04, 2023 at 07:04:48PM +0800, Macpaul Lin wrote: > From: Fabien Parent > > Add mt8195-demo board support. > This demo purpose board uses MediaTek's MT8195 SoC. > > Signed-off-by: Fabien Parent > Signed-off-by: Amjad Ouled-Ameur > Signed-off-by: Macpaul Lin [snip] > diff --git a/b

[PATCH v5 2/2] board: mediatek: add mt8195 demo board

From: Fabien Parent Add mt8195-demo board support. This demo purpose board uses MediaTek's MT8195 SoC. Signed-off-by: Fabien Parent Signed-off-by: Amjad Ouled-Ameur Signed-off-by: Macpaul Lin --- MAINTAINERS | 1 + arch/arm/dts/Makefile | 1 + arch/a