Re: [PATCH v4 20/29] lib/crypto: Adapt x509_cert_parser to MbedTLS

2024-07-29 Thread Raymond Mao
On Mon, 29 Jul 2024 at 09:20, Ilias Apalodimas wrote: > Hi Raymond > > > > > +#if CONFIG_IS_ENABLED(MBEDTLS_LIB_X509) > > +/* Backup of part of the parsing context */ > > I am not sure I understand the comment > > We can remove this comment line. > > +struct x509_cert_mbedtls_ctx { > > +

Re: [PATCH v4 20/29] lib/crypto: Adapt x509_cert_parser to MbedTLS

2024-07-29 Thread Ilias Apalodimas
Hi Raymond > > +#if CONFIG_IS_ENABLED(MBEDTLS_LIB_X509) > +/* Backup of part of the parsing context */ I am not sure I understand the comment > +struct x509_cert_mbedtls_ctx { > + void*tbs; /* Signed data */ > + void*raw_serial;/* Raw serial numb

[PATCH v4 20/29] lib/crypto: Adapt x509_cert_parser to MbedTLS

2024-07-02 Thread Raymond Mao
Previous patch has introduced MbedTLS porting layer for x509 cert parser, here to adjust the header and makefiles accordingly. Signed-off-by: Raymond Mao --- Changes in v2 - Move the porting layer to MbedTLS dir. Changes in v3 - Update commit message. Changes in v4 - Control building legacy libra