Re: [PATCH v4 10/16] dm: gpio: Add a way to update flags

2021-03-04 Thread Tom Rini
On Thu, Feb 04, 2021 at 09:22:03PM -0700, Simon Glass wrote: > It is convenient to be able to adjust some of the flags for a GPIO while > leaving others alone. Add a function for this. > > Update dm_gpio_set_dir_flags() to make use of this. > > Also update dm_gpio_set_value() to use this also, s

Re: [PATCH v4 10/16] dm: gpio: Add a way to update flags

2021-02-12 Thread Simon Glass
Hi Patrick, On Wed, 10 Feb 2021 at 01:38, Patrick DELAUNAY wrote: > > > On 2/9/21 5:28 AM, Simon Glass wrote: > > Hi Patrick, > > > > On Mon, 8 Feb 2021 at 10:33, Patrick DELAUNAY > > wrote: > >> Hi Simon, > >> > >> 2 minor remarks, > >> > >> On 2/5/21 5:22 AM, Simon Glass wrote: > >>> It is con

Re: [PATCH v4 10/16] dm: gpio: Add a way to update flags

2021-02-10 Thread Patrick DELAUNAY
On 2/9/21 5:28 AM, Simon Glass wrote: Hi Patrick, On Mon, 8 Feb 2021 at 10:33, Patrick DELAUNAY wrote: Hi Simon, 2 minor remarks, On 2/5/21 5:22 AM, Simon Glass wrote: It is convenient to be able to adjust some of the flags for a GPIO while leaving others alone. Add a function for this.

Re: [PATCH v4 10/16] dm: gpio: Add a way to update flags

2021-02-08 Thread Simon Glass
Hi Patrick, On Mon, 8 Feb 2021 at 10:33, Patrick DELAUNAY wrote: > > Hi Simon, > > 2 minor remarks, > > On 2/5/21 5:22 AM, Simon Glass wrote: > > It is convenient to be able to adjust some of the flags for a GPIO while > > leaving others alone. Add a function for this. > > > > Update dm_gpio_set_

Re: [PATCH v4 10/16] dm: gpio: Add a way to update flags

2021-02-08 Thread Patrick DELAUNAY
Hi Simon, 2 minor remarks, On 2/5/21 5:22 AM, Simon Glass wrote: It is convenient to be able to adjust some of the flags for a GPIO while leaving others alone. Add a function for this. Update dm_gpio_set_dir_flags() to make use of this. Also update dm_gpio_set_value() to use this also, since

Re: [PATCH v4 10/16] dm: gpio: Add a way to update flags

2021-02-08 Thread Köry Maincent
On Thu, 4 Feb 2021 21:22:03 -0700 Simon Glass wrote: > It is convenient to be able to adjust some of the flags for a GPIO while > leaving others alone. Add a function for this. > > Update dm_gpio_set_dir_flags() to make use of this. > > Also update dm_gpio_set_value() to use this also, since t

[PATCH v4 10/16] dm: gpio: Add a way to update flags

2021-02-04 Thread Simon Glass
It is convenient to be able to adjust some of the flags for a GPIO while leaving others alone. Add a function for this. Update dm_gpio_set_dir_flags() to make use of this. Also update dm_gpio_set_value() to use this also, since this allows the open-drain / open-source features to be implemented d