Re: [PATCH v4 1/9] CONFIG_NR_DRAM_BANKS: Remove unreferenced code as its always defined

2020-08-18 Thread Tom Rini
On Tue, Aug 18, 2020 at 12:31:32PM +0200, Wolfgang Denk wrote: > Dear Stefan Roese, > > In message <20200813054800.469284-2...@denx.de> you wrote: > > Since commit 86cf1c82850f ("configs: Migrate CONFIG_NR_DRAM_BANKS") & > > commit 999a772d9f24 ("Kconfig: Migrate CONFIG_NR_DRAM_BANKS"), > > CONFIG

Re: [PATCH v4 1/9] CONFIG_NR_DRAM_BANKS: Remove unreferenced code as its always defined

2020-08-18 Thread Wolfgang Denk
Dear Stefan, In message <8ddb672c-956c-68d2-ceb4-d77f96cdf...@denx.de> you wrote: > > > Especially the default value of 4 makes no sense to me - whiy is > > this not 1? > > I can't really tell. I can only assume, that it originates from this > patch: Yes, probably. I think the issue here resutls

Re: [PATCH v4 1/9] CONFIG_NR_DRAM_BANKS: Remove unreferenced code as its always defined

2020-08-18 Thread Stefan Roese
Hi Wolfgang, (added Ramon to Cc) On 18.08.20 12:31, Wolfgang Denk wrote: In message <20200813054800.469284-2...@denx.de> you wrote: Since commit 86cf1c82850f ("configs: Migrate CONFIG_NR_DRAM_BANKS") & commit 999a772d9f24 ("Kconfig: Migrate CONFIG_NR_DRAM_BANKS"), CONFIG_NR_DRAM_BANKS is alway

Re: [PATCH v4 1/9] CONFIG_NR_DRAM_BANKS: Remove unreferenced code as its always defined

2020-08-18 Thread Wolfgang Denk
Dear Stefan Roese, In message <20200813054800.469284-2...@denx.de> you wrote: > Since commit 86cf1c82850f ("configs: Migrate CONFIG_NR_DRAM_BANKS") & > commit 999a772d9f24 ("Kconfig: Migrate CONFIG_NR_DRAM_BANKS"), > CONFIG_NR_DRAM_BANKS is always defined with a value (4 is default). Has there be

Re: [PATCH v4 1/9] CONFIG_NR_DRAM_BANKS: Remove unreferenced code as its always defined

2020-08-13 Thread Andy Shevchenko
On Thu, Aug 13, 2020 at 01:28:29PM +0200, Stefan Roese wrote: > On 13.08.20 13:14, Andy Shevchenko wrote: > > On Thu, Aug 13, 2020 at 07:47:52AM +0200, Stefan Roese wrote: > > > Since commit 86cf1c82850f ("configs: Migrate CONFIG_NR_DRAM_BANKS") & > > > commit 999a772d9f24 ("Kconfig: Migrate CONFIG

Re: [PATCH v4 1/9] CONFIG_NR_DRAM_BANKS: Remove unreferenced code as its always defined

2020-08-13 Thread Stefan Roese
On 13.08.20 13:14, Andy Shevchenko wrote: On Thu, Aug 13, 2020 at 07:47:52AM +0200, Stefan Roese wrote: Since commit 86cf1c82850f ("configs: Migrate CONFIG_NR_DRAM_BANKS") & commit 999a772d9f24 ("Kconfig: Migrate CONFIG_NR_DRAM_BANKS"), CONFIG_NR_DRAM_BANKS is always defined with a value (4 is d

Re: [PATCH v4 1/9] CONFIG_NR_DRAM_BANKS: Remove unreferenced code as its always defined

2020-08-13 Thread Andy Shevchenko
On Thu, Aug 13, 2020 at 07:47:52AM +0200, Stefan Roese wrote: > Since commit 86cf1c82850f ("configs: Migrate CONFIG_NR_DRAM_BANKS") & > commit 999a772d9f24 ("Kconfig: Migrate CONFIG_NR_DRAM_BANKS"), > CONFIG_NR_DRAM_BANKS is always defined with a value (4 is default). > It makes no sense to still c

Re: [PATCH v4 1/9] CONFIG_NR_DRAM_BANKS: Remove unreferenced code as its always defined

2020-08-13 Thread Andy Shevchenko
On Thu, Aug 13, 2020 at 07:47:52AM +0200, Stefan Roese wrote: > Since commit 86cf1c82850f ("configs: Migrate CONFIG_NR_DRAM_BANKS") & > commit 999a772d9f24 ("Kconfig: Migrate CONFIG_NR_DRAM_BANKS"), > CONFIG_NR_DRAM_BANKS is always defined with a value (4 is default). > It makes no sense to still c

Re: [PATCH v4 1/9] CONFIG_NR_DRAM_BANKS: Remove unreferenced code as its always defined

2020-08-13 Thread Pali Rohár
On Thursday 13 August 2020 07:47:52 Stefan Roese wrote: > Since commit 86cf1c82850f ("configs: Migrate CONFIG_NR_DRAM_BANKS") & > commit 999a772d9f24 ("Kconfig: Migrate CONFIG_NR_DRAM_BANKS"), > CONFIG_NR_DRAM_BANKS is always defined with a value (4 is default). > It makes no sense to still carry c

[PATCH v4 1/9] CONFIG_NR_DRAM_BANKS: Remove unreferenced code as its always defined

2020-08-12 Thread Stefan Roese
Since commit 86cf1c82850f ("configs: Migrate CONFIG_NR_DRAM_BANKS") & commit 999a772d9f24 ("Kconfig: Migrate CONFIG_NR_DRAM_BANKS"), CONFIG_NR_DRAM_BANKS is always defined with a value (4 is default). It makes no sense to still carry code that is guarded with "#ifndef CONFIG_NR_DRAM_BANKS" (and sim