>> Typically what happens in open-source projects is that once the code is
>> merged, the contributor disappears :) So there's usually reticence to
>> merging code if there's some on-going discussion. Here, the struct for
>> cmd change suggestion is not a blocker as it's mostly cosmetic anyway
>> a
Hi Jean-Marie,
On 5/19/25 11:05 AM, Verdun, Jean-Marie wrote:
Fair enough. You could have the same ternary operator to better match
what's in the kernel.
Can you also reuse the macros that are in the kernel already?
W5500_SPI_BLOCK_SELECT, W5500_SPI_READ_CONTROL and
W5500_SPI_WRITE_CONTROL se
Hi Jean-Marie,
On 5/15/25 4:01 PM, Verdun, Jean-Marie wrote:
This is dangerous too. How do I know if the returned data is an error
code or actual data?
Right now, xfer returns 0 if successful, -1 otherwise. I would suggest
return ret only if it is < 0.
Or even better, propagate the erro
>> Fair enough. You could have the same ternary operator to better match
>> what's in the kernel.
>> Can you also reuse the macros that are in the kernel already?
>> W5500_SPI_BLOCK_SELECT, W5500_SPI_READ_CONTROL and
>> W5500_SPI_WRITE_CONTROL seems to be of interest?
I will check it
>> If you d
>> This is dangerous too. How do I know if the returned data is an error
>> code or actual data?
>> Right now, xfer returns 0 if successful, -1 otherwise. I would suggest
>> return ret only if it is < 0.
>> Or even better, propagate the error code and return data through a
>> pointer as argume
Hi Neil, Jean-Marie,
On 5/12/25 10:10 AM, neil.armstr...@linaro.org wrote:
Hi,
Thanks for fixing it !
On 11/05/2025 20:02, ver...@hpe.com wrote:
From: Jean-Marie Verdun
Add support for the Wiznet W5500 spi to ethernet controller
Signed-off-by: Jean-Marie Verdun
---
drivers/net/Kconfig
Hi,
Thanks for fixing it !
On 11/05/2025 20:02, ver...@hpe.com wrote:
From: Jean-Marie Verdun
Add support for the Wiznet W5500 spi to ethernet controller
Signed-off-by: Jean-Marie Verdun
---
drivers/net/Kconfig | 9 +
drivers/net/Makefile | 1 +
drivers/net/w5500.c | 584 +
From: Jean-Marie Verdun
Add support for the Wiznet W5500 spi to ethernet controller
Signed-off-by: Jean-Marie Verdun
---
drivers/net/Kconfig | 9 +
drivers/net/Makefile | 1 +
drivers/net/w5500.c | 584 +++
3 files changed, 594 insertions(+)
creat
8 matches
Mail list logo
