Re: [PATCH v4 04/25] efi_loader: Add comments where incorrect addresses are used

2024-12-03 Thread Simon Glass
Hi Tom, On Tue, 3 Dec 2024 at 07:09, Tom Rini wrote: > > On Tue, Dec 03, 2024 at 06:45:58AM -0700, Simon Glass wrote: > > Hi Ilias, > > > > On Tue, 3 Dec 2024 at 01:49, Ilias Apalodimas > > wrote: > > > > > > Hi Simon, > > > > > > On Tue, 3 Dec 2024 at 02:22, Simon Glass wrote: > > > > > > > >

Re: [PATCH v4 04/25] efi_loader: Add comments where incorrect addresses are used

2024-12-03 Thread Tom Rini
On Tue, Dec 03, 2024 at 06:45:58AM -0700, Simon Glass wrote: > Hi Ilias, > > On Tue, 3 Dec 2024 at 01:49, Ilias Apalodimas > wrote: > > > > Hi Simon, > > > > On Tue, 3 Dec 2024 at 02:22, Simon Glass wrote: > > > > > > Hi Tom, > > > > > > On Mon, 2 Dec 2024 at 13:18, Tom Rini wrote: > > > > > >

Re: [PATCH v4 04/25] efi_loader: Add comments where incorrect addresses are used

2024-12-03 Thread Simon Glass
Hi Ilias, On Tue, 3 Dec 2024 at 01:49, Ilias Apalodimas wrote: > > Hi Simon, > > On Tue, 3 Dec 2024 at 02:22, Simon Glass wrote: > > > > Hi Tom, > > > > On Mon, 2 Dec 2024 at 13:18, Tom Rini wrote: > > > > > > On Sun, Dec 01, 2024 at 08:24:23AM -0700, Simon Glass wrote: > > > > > > > Some funct

Re: [PATCH v4 04/25] efi_loader: Add comments where incorrect addresses are used

2024-12-03 Thread Ilias Apalodimas
Hi Simon, On Tue, 3 Dec 2024 at 02:22, Simon Glass wrote: > > Hi Tom, > > On Mon, 2 Dec 2024 at 13:18, Tom Rini wrote: > > > > On Sun, Dec 01, 2024 at 08:24:23AM -0700, Simon Glass wrote: > > > > > Some functions are passing addresses instead of pointers to the > > > efi_add_memory_map() functio

Re: [PATCH v4 04/25] efi_loader: Add comments where incorrect addresses are used

2024-12-02 Thread Tom Rini
On Mon, Dec 02, 2024 at 05:22:44PM -0700, Simon Glass wrote: > Hi Tom, > > On Mon, 2 Dec 2024 at 13:18, Tom Rini wrote: > > > > On Sun, Dec 01, 2024 at 08:24:23AM -0700, Simon Glass wrote: > > > > > Some functions are passing addresses instead of pointers to the > > > efi_add_memory_map() functio

Re: [PATCH v4 04/25] efi_loader: Add comments where incorrect addresses are used

2024-12-02 Thread Simon Glass
Hi Tom, On Mon, 2 Dec 2024 at 13:18, Tom Rini wrote: > > On Sun, Dec 01, 2024 at 08:24:23AM -0700, Simon Glass wrote: > > > Some functions are passing addresses instead of pointers to the > > efi_add_memory_map() function. This confusion is understandable since > > the function arguments indicate

Re: [PATCH v4 04/25] efi_loader: Add comments where incorrect addresses are used

2024-12-02 Thread Tom Rini
On Sun, Dec 01, 2024 at 08:24:23AM -0700, Simon Glass wrote: > Some functions are passing addresses instead of pointers to the > efi_add_memory_map() function. This confusion is understandable since > the function arguments indicate an address. > > Make a note of the 8 places where there are prob

[PATCH v4 04/25] efi_loader: Add comments where incorrect addresses are used

2024-12-01 Thread Simon Glass
Some functions are passing addresses instead of pointers to the efi_add_memory_map() function. This confusion is understandable since the function arguments indicate an address. Make a note of the 8 places where there are problems, which would break usage in sandbox tests. Future work will resolv