Re: [PATCH v4 02/10] rockchip: binman: Factor out arch and compression

2025-04-10 Thread Quentin Schulz
Hi Jonas, On 4/9/25 1:56 PM, Jonas Karlman wrote: Hi Quentin, On 2025-04-09 11:28, Quentin Schulz wrote: Hi Jonas, Simon, On 3/29/25 4:06 PM, Jonas Karlman wrote: From: Simon Glass Declare arch and compression at the top of the file to avoid needing ifdefs in every usage. Add a few commen

Re: [PATCH v4 02/10] rockchip: binman: Factor out arch and compression

2025-04-10 Thread Jonas Karlman
Hi Quentin, On 2025-04-09 14:27, Quentin Schulz wrote: > Hi Jonas, > > On 4/9/25 1:56 PM, Jonas Karlman wrote: >> Hi Quentin, >> >> On 2025-04-09 11:28, Quentin Schulz wrote: >>> Hi Jonas, Simon, >>> >>> On 3/29/25 4:06 PM, Jonas Karlman wrote: From: Simon Glass Declare arch and c

Re: [PATCH v4 02/10] rockchip: binman: Factor out arch and compression

2025-04-09 Thread Jonas Karlman
Hi Quentin, On 2025-04-09 11:28, Quentin Schulz wrote: > Hi Jonas, Simon, > > On 3/29/25 4:06 PM, Jonas Karlman wrote: >> From: Simon Glass >> >> Declare arch and compression at the top of the file to avoid needing >> ifdefs in every usage. >> >> Add a few comments to help with the remaining #if

Re: [PATCH v4 02/10] rockchip: binman: Factor out arch and compression

2025-04-09 Thread Quentin Schulz
Hi Jonas, Simon, On 3/29/25 4:06 PM, Jonas Karlman wrote: From: Simon Glass Declare arch and compression at the top of the file to avoid needing ifdefs in every usage. Add a few comments to help with the remaining #ifdefs. Signed-off-by: Simon Glass Signed-off-by: Jonas Karlman --- Changes

Re: [PATCH v4 02/10] rockchip: binman: Factor out arch and compression

2025-04-06 Thread Kever Yang
On 2025/3/29 23:06, Jonas Karlman wrote: From: Simon Glass Declare arch and compression at the top of the file to avoid needing ifdefs in every usage. Add a few comments to help with the remaining #ifdefs. Signed-off-by: Simon Glass Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang

[PATCH v4 02/10] rockchip: binman: Factor out arch and compression

2025-03-29 Thread Jonas Karlman
From: Simon Glass Declare arch and compression at the top of the file to avoid needing ifdefs in every usage. Add a few comments to help with the remaining #ifdefs. Signed-off-by: Simon Glass Signed-off-by: Jonas Karlman --- Changes in v4: - Split from "VBE serial part H: Implement VBE on Roc